Skip to content

Conversation

@ami7ava
Copy link
Contributor

@ami7ava ami7ava commented Apr 5, 2014

No description provided.

@gnufied
Copy link
Contributor

gnufied commented Apr 5, 2014

Can we rebase this on top of refactor-reactor because constant loading etc changed there.

@gnufied
Copy link
Contributor

gnufied commented Apr 5, 2014

So about pid location and another thing,

a. I think Invoker should log its logs to a file when daemonized. As in ~/.invoker/invoker.log
b. Similarly the pid then can be written in ~/.invoker/invoker.pid

What you think?

@ami7ava
Copy link
Contributor Author

ami7ava commented Apr 5, 2014

Do we still need to log when tail command is available?

@gnufied
Copy link
Contributor

gnufied commented Apr 5, 2014

tail command only sends individual process logs, what if invoker crashes or errors out? For those cases invoker its own logs should always be written somewhere, I think.

@ami7ava
Copy link
Contributor Author

ami7ava commented Apr 5, 2014

What happens to the ~/.invoker file already created by Invoker::Power. Cannot create a directory with the same name.

@gnufied
Copy link
Contributor

gnufied commented Apr 5, 2014

ah, damn.yeah that is the tricky. Is there a way for existing installations we can move ~/.invoker file inside ~/.invoker directory and rename ~/.invoker file to ~/.invoker/config ?

ami7ava and others added 3 commits April 6, 2014 01:45
Follow the existing pattern of defining accessor methods.
Also move the old .invoker file to ~/.invoker/config
User can tail more than one process at once.
Also fixed minor issues with when invoker is not running.
@gnufied
Copy link
Contributor

gnufied commented Apr 6, 2014

One small thing with now ability to daemonize invoker, people can by mistake try and run two invokers. One daemonized one and another non-daemonize one. We should protect them from that.

ami7ava pushed a commit that referenced this pull request Apr 7, 2014
Add option to run Invoker as daemon

Closes #41 #42
@ami7ava ami7ava merged commit 5cba099 into master Apr 7, 2014
@ami7ava ami7ava deleted the daemonize branch April 7, 2014 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants