Skip to content

Commit 8c0bf96

Browse files
pull[bot]pull[bot]
committed
[DevTools] Render selected outline on top of every other rect (facebook#35012)
When rects are close together (or overlapping) the outline can end up being covered up by sibling rects or deeper rects. This renders the selected outline on top of everything so it's always visible. <img width="275" height="730" alt="Screenshot 2025-10-29 at 8 43 28 PM" src="https://github.com/user-attachments/assets/69224883-f548-45ec-ada1-1a04ec17eaf5" /> <img width="266" height="737" alt="Screenshot 2025-10-29 at 8 58 53 PM" src="https://github.com/user-attachments/assets/946f7dde-450d-49fd-9fbd-57487f67f461" /> Additionally, this makes it so that it's not part of the translucent tree when things are hidden by the timeline. That way it's easier to see what is selected inside a hidden tree. <img width="498" height="196" alt="Screenshot 2025-10-29 at 8 45 24 PM" src="https://github.com/user-attachments/assets/723107ab-a92c-42c2-8a7d-a548ac3332d0" /> <img width="571" height="735" alt="Screenshot 2025-10-29 at 8 59 06 PM" src="https://github.com/user-attachments/assets/d653f1a7-4096-45c3-b92a-ef155d4742e6" /> DiffTrain build for [6fb7754](facebook@6fb7754)
1 parent a855864 commit 8c0bf96

File tree

21 files changed

+72
-72
lines changed

21 files changed

+72
-72
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.3.0-native-fb-3a0ab8a7-20251029
1+
19.3.0-native-fb-6fb77544-20251030

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<2fa4486f02e27cc504aee043bf8a14cb>>
10+
* @generated SignedSource<<59de08049f5c9a57c58d1c7278a0761c>>
1111
*/
1212

1313
"use strict";
@@ -414,5 +414,5 @@ __DEV__ &&
414414
exports.useFormStatus = function () {
415415
return resolveDispatcher().useHostTransitionStatus();
416416
};
417-
exports.version = "19.3.0-native-fb-3a0ab8a7-20251029";
417+
exports.version = "19.3.0-native-fb-6fb77544-20251030";
418418
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<a640364eab7add93b41d4111387f9d1c>>
10+
* @generated SignedSource<<688b0c20036fbcb7a8709ea022bae8ce>>
1111
*/
1212

1313
"use strict";
@@ -209,4 +209,4 @@ exports.useFormState = function (action, initialState, permalink) {
209209
exports.useFormStatus = function () {
210210
return ReactSharedInternals.H.useHostTransitionStatus();
211211
};
212-
exports.version = "19.3.0-native-fb-3a0ab8a7-20251029";
212+
exports.version = "19.3.0-native-fb-6fb77544-20251030";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<a640364eab7add93b41d4111387f9d1c>>
10+
* @generated SignedSource<<688b0c20036fbcb7a8709ea022bae8ce>>
1111
*/
1212

1313
"use strict";
@@ -209,4 +209,4 @@ exports.useFormState = function (action, initialState, permalink) {
209209
exports.useFormStatus = function () {
210210
return ReactSharedInternals.H.useHostTransitionStatus();
211211
};
212-
exports.version = "19.3.0-native-fb-3a0ab8a7-20251029";
212+
exports.version = "19.3.0-native-fb-6fb77544-20251030";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<8df0c5e88f9f612e6120035047eaf2df>>
10+
* @generated SignedSource<<4aae758ef9582e861253d1eb22f98143>>
1111
*/
1212

1313
/*
@@ -29744,11 +29744,11 @@ __DEV__ &&
2974429744
};
2974529745
(function () {
2974629746
var isomorphicReactPackageVersion = React.version;
29747-
if ("19.3.0-native-fb-3a0ab8a7-20251029" !== isomorphicReactPackageVersion)
29747+
if ("19.3.0-native-fb-6fb77544-20251030" !== isomorphicReactPackageVersion)
2974829748
throw Error(
2974929749
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2975029750
(isomorphicReactPackageVersion +
29751-
"\n - react-dom: 19.3.0-native-fb-3a0ab8a7-20251029\nLearn more: https://react.dev/warnings/version-mismatch")
29751+
"\n - react-dom: 19.3.0-native-fb-6fb77544-20251030\nLearn more: https://react.dev/warnings/version-mismatch")
2975229752
);
2975329753
})();
2975429754
("function" === typeof Map &&
@@ -29785,10 +29785,10 @@ __DEV__ &&
2978529785
!(function () {
2978629786
var internals = {
2978729787
bundleType: 1,
29788-
version: "19.3.0-native-fb-3a0ab8a7-20251029",
29788+
version: "19.3.0-native-fb-6fb77544-20251030",
2978929789
rendererPackageName: "react-dom",
2979029790
currentDispatcherRef: ReactSharedInternals,
29791-
reconcilerVersion: "19.3.0-native-fb-3a0ab8a7-20251029"
29791+
reconcilerVersion: "19.3.0-native-fb-6fb77544-20251030"
2979229792
};
2979329793
internals.overrideHookState = overrideHookState;
2979429794
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -29938,5 +29938,5 @@ __DEV__ &&
2993829938
listenToAllSupportedEvents(container);
2993929939
return new ReactDOMHydrationRoot(initialChildren);
2994029940
};
29941-
exports.version = "19.3.0-native-fb-3a0ab8a7-20251029";
29941+
exports.version = "19.3.0-native-fb-6fb77544-20251030";
2994229942
})();

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<d090dc3cef06d6248954045e4276aa6b>>
10+
* @generated SignedSource<<e7caaed0189ddb73d1d55f53bd59e57e>>
1111
*/
1212

1313
/*
@@ -17374,14 +17374,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1737417374
};
1737517375
var isomorphicReactPackageVersion$jscomp$inline_2058 = React.version;
1737617376
if (
17377-
"19.3.0-native-fb-3a0ab8a7-20251029" !==
17377+
"19.3.0-native-fb-6fb77544-20251030" !==
1737817378
isomorphicReactPackageVersion$jscomp$inline_2058
1737917379
)
1738017380
throw Error(
1738117381
formatProdErrorMessage(
1738217382
527,
1738317383
isomorphicReactPackageVersion$jscomp$inline_2058,
17384-
"19.3.0-native-fb-3a0ab8a7-20251029"
17384+
"19.3.0-native-fb-6fb77544-20251030"
1738517385
)
1738617386
);
1738717387
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17403,10 +17403,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1740317403
};
1740417404
var internals$jscomp$inline_2661 = {
1740517405
bundleType: 0,
17406-
version: "19.3.0-native-fb-3a0ab8a7-20251029",
17406+
version: "19.3.0-native-fb-6fb77544-20251030",
1740717407
rendererPackageName: "react-dom",
1740817408
currentDispatcherRef: ReactSharedInternals,
17409-
reconcilerVersion: "19.3.0-native-fb-3a0ab8a7-20251029"
17409+
reconcilerVersion: "19.3.0-native-fb-6fb77544-20251030"
1741017410
};
1741117411
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1741217412
var hook$jscomp$inline_2662 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17513,4 +17513,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1751317513
listenToAllSupportedEvents(container);
1751417514
return new ReactDOMHydrationRoot(initialChildren);
1751517515
};
17516-
exports.version = "19.3.0-native-fb-3a0ab8a7-20251029";
17516+
exports.version = "19.3.0-native-fb-6fb77544-20251030";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<c5c90a07139283fd0971cc9226f8dd87>>
10+
* @generated SignedSource<<8a48da9ca0d677882a577be102ed41b8>>
1111
*/
1212

1313
/*
@@ -19478,14 +19478,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1947819478
};
1947919479
var isomorphicReactPackageVersion$jscomp$inline_2373 = React.version;
1948019480
if (
19481-
"19.3.0-native-fb-3a0ab8a7-20251029" !==
19481+
"19.3.0-native-fb-6fb77544-20251030" !==
1948219482
isomorphicReactPackageVersion$jscomp$inline_2373
1948319483
)
1948419484
throw Error(
1948519485
formatProdErrorMessage(
1948619486
527,
1948719487
isomorphicReactPackageVersion$jscomp$inline_2373,
19488-
"19.3.0-native-fb-3a0ab8a7-20251029"
19488+
"19.3.0-native-fb-6fb77544-20251030"
1948919489
)
1949019490
);
1949119491
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19507,10 +19507,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1950719507
};
1950819508
var internals$jscomp$inline_2380 = {
1950919509
bundleType: 0,
19510-
version: "19.3.0-native-fb-3a0ab8a7-20251029",
19510+
version: "19.3.0-native-fb-6fb77544-20251030",
1951119511
rendererPackageName: "react-dom",
1951219512
currentDispatcherRef: ReactSharedInternals,
19513-
reconcilerVersion: "19.3.0-native-fb-3a0ab8a7-20251029",
19513+
reconcilerVersion: "19.3.0-native-fb-6fb77544-20251030",
1951419514
getLaneLabelMap: function () {
1951519515
for (
1951619516
var map = new Map(), lane = 1, index$323 = 0;
@@ -19633,4 +19633,4 @@ exports.hydrateRoot = function (container, initialChildren, options) {
1963319633
listenToAllSupportedEvents(container);
1963419634
return new ReactDOMHydrationRoot(initialChildren);
1963519635
};
19636-
exports.version = "19.3.0-native-fb-3a0ab8a7-20251029";
19636+
exports.version = "19.3.0-native-fb-6fb77544-20251030";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-dev.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<89f826c4220d0fd707b29702e1874465>>
10+
* @generated SignedSource<<bc027baf5f0f60b82a4821ca2e858a31>>
1111
*/
1212

1313
/*
@@ -29800,11 +29800,11 @@ __DEV__ &&
2980029800
};
2980129801
(function () {
2980229802
var isomorphicReactPackageVersion = React.version;
29803-
if ("19.3.0-native-fb-3a0ab8a7-20251029" !== isomorphicReactPackageVersion)
29803+
if ("19.3.0-native-fb-6fb77544-20251030" !== isomorphicReactPackageVersion)
2980429804
throw Error(
2980529805
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2980629806
(isomorphicReactPackageVersion +
29807-
"\n - react-dom: 19.3.0-native-fb-3a0ab8a7-20251029\nLearn more: https://react.dev/warnings/version-mismatch")
29807+
"\n - react-dom: 19.3.0-native-fb-6fb77544-20251030\nLearn more: https://react.dev/warnings/version-mismatch")
2980829808
);
2980929809
})();
2981029810
("function" === typeof Map &&
@@ -29841,10 +29841,10 @@ __DEV__ &&
2984129841
!(function () {
2984229842
var internals = {
2984329843
bundleType: 1,
29844-
version: "19.3.0-native-fb-3a0ab8a7-20251029",
29844+
version: "19.3.0-native-fb-6fb77544-20251030",
2984529845
rendererPackageName: "react-dom",
2984629846
currentDispatcherRef: ReactSharedInternals,
29847-
reconcilerVersion: "19.3.0-native-fb-3a0ab8a7-20251029"
29847+
reconcilerVersion: "19.3.0-native-fb-6fb77544-20251030"
2984829848
};
2984929849
internals.overrideHookState = overrideHookState;
2985029850
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -30324,7 +30324,7 @@ __DEV__ &&
3032430324
exports.useFormStatus = function () {
3032530325
return resolveDispatcher().useHostTransitionStatus();
3032630326
};
30327-
exports.version = "19.3.0-native-fb-3a0ab8a7-20251029";
30327+
exports.version = "19.3.0-native-fb-6fb77544-20251030";
3032830328
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
3032930329
"function" ===
3033030330
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-prod.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<f0862f2cb73ed99838b8dbdd8fd0cc7e>>
10+
* @generated SignedSource<<9b70d21c0cefee852a3723932baf0eea>>
1111
*/
1212

1313
/*
@@ -17385,14 +17385,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1738517385
};
1738617386
var isomorphicReactPackageVersion$jscomp$inline_2059 = React.version;
1738717387
if (
17388-
"19.3.0-native-fb-3a0ab8a7-20251029" !==
17388+
"19.3.0-native-fb-6fb77544-20251030" !==
1738917389
isomorphicReactPackageVersion$jscomp$inline_2059
1739017390
)
1739117391
throw Error(
1739217392
formatProdErrorMessage(
1739317393
527,
1739417394
isomorphicReactPackageVersion$jscomp$inline_2059,
17395-
"19.3.0-native-fb-3a0ab8a7-20251029"
17395+
"19.3.0-native-fb-6fb77544-20251030"
1739617396
)
1739717397
);
1739817398
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -17414,10 +17414,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1741417414
};
1741517415
var internals$jscomp$inline_2664 = {
1741617416
bundleType: 0,
17417-
version: "19.3.0-native-fb-3a0ab8a7-20251029",
17417+
version: "19.3.0-native-fb-6fb77544-20251030",
1741817418
rendererPackageName: "react-dom",
1741917419
currentDispatcherRef: ReactSharedInternals,
17420-
reconcilerVersion: "19.3.0-native-fb-3a0ab8a7-20251029"
17420+
reconcilerVersion: "19.3.0-native-fb-6fb77544-20251030"
1742117421
};
1742217422
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1742317423
var hook$jscomp$inline_2665 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17684,4 +17684,4 @@ exports.useFormState = function (action, initialState, permalink) {
1768417684
exports.useFormStatus = function () {
1768517685
return ReactSharedInternals.H.useHostTransitionStatus();
1768617686
};
17687-
exports.version = "19.3.0-native-fb-3a0ab8a7-20251029";
17687+
exports.version = "19.3.0-native-fb-6fb77544-20251030";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMProfiling-profiling.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<eff2bba1e27565b2ac1bf027448fdae4>>
10+
* @generated SignedSource<<037ace4ce94a2e797d3a209ca17cfb3c>>
1111
*/
1212

1313
/*
@@ -19493,14 +19493,14 @@ ReactDOMHydrationRoot.prototype.unstable_scheduleHydration = function (target) {
1949319493
};
1949419494
var isomorphicReactPackageVersion$jscomp$inline_2374 = React.version;
1949519495
if (
19496-
"19.3.0-native-fb-3a0ab8a7-20251029" !==
19496+
"19.3.0-native-fb-6fb77544-20251030" !==
1949719497
isomorphicReactPackageVersion$jscomp$inline_2374
1949819498
)
1949919499
throw Error(
1950019500
formatProdErrorMessage(
1950119501
527,
1950219502
isomorphicReactPackageVersion$jscomp$inline_2374,
19503-
"19.3.0-native-fb-3a0ab8a7-20251029"
19503+
"19.3.0-native-fb-6fb77544-20251030"
1950419504
)
1950519505
);
1950619506
ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
@@ -19522,10 +19522,10 @@ ReactDOMSharedInternals.findDOMNode = function (componentOrElement) {
1952219522
};
1952319523
var internals$jscomp$inline_2381 = {
1952419524
bundleType: 0,
19525-
version: "19.3.0-native-fb-3a0ab8a7-20251029",
19525+
version: "19.3.0-native-fb-6fb77544-20251030",
1952619526
rendererPackageName: "react-dom",
1952719527
currentDispatcherRef: ReactSharedInternals,
19528-
reconcilerVersion: "19.3.0-native-fb-3a0ab8a7-20251029",
19528+
reconcilerVersion: "19.3.0-native-fb-6fb77544-20251030",
1952919529
getLaneLabelMap: function () {
1953019530
for (
1953119531
var map = new Map(), lane = 1, index$323 = 0;
@@ -19808,7 +19808,7 @@ exports.useFormState = function (action, initialState, permalink) {
1980819808
exports.useFormStatus = function () {
1980919809
return ReactSharedInternals.H.useHostTransitionStatus();
1981019810
};
19811-
exports.version = "19.3.0-native-fb-3a0ab8a7-20251029";
19811+
exports.version = "19.3.0-native-fb-6fb77544-20251030";
1981219812
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1981319813
"function" ===
1981419814
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)