-
Notifications
You must be signed in to change notification settings - Fork 20
fix search error #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix search error #472
Conversation
✅ Deploy Preview for tsml-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Nice global fix.
One issue that I found in my testing:
- If you enter a string with all permitted characters 'sober' and move the insertion point to something other than the end, and then type an non-permitted character, the insertion point is moved to the end of the string in the search bar
Not a big deal, but an interesting side effect.
Another issue that comes to mind is how to search for a meeting with one of those excluded characters in their names.
For example if I had a group named "Faithful $5ers", I wouldn't be able to search on "$5"
Not that I could so today anyhow, so perhaps this fix would make this more obvious since I wouldn't be able to type the character into the search field in the first place.
thanks for testing!
that's fine
are you sure? this PR now sanitizes the search index |
sounds good.
So the the search index would get "Faithful" "5ers"... hmmm |
this PR: