Revert "Streamlined return values from grab* (#2054)" #2070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4a769f1.
|
I think, we should no revert everything, just make PR with previous signature |
|
grab* will be fixed in #2098 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4a769f1.
Previous PR broke backwards compatibility.
We will change how grab* methods work but once we will be releasing 3.0
Motivation/Description of the PR
Applicable helpers:
[ x ] Webdriver
Puppeteer
Nightmare
REST
Appium
Protractor
TestCafe
Description of this PR, which problem it solves
A link to the corresponding issue (if applicable).
Type of change
Checklist:
npm run docs)npm run lint)npm test)