Add grab*FromAll method #2098
Merged
Add grab*FromAll method #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vorobeyko
reviewed
Dec 22, 2019
|
I have created a new document under webapi folder. But when I try to generate document It also makes changes which I did not change. Maybe it would have been missed in previous merges. (So I did not add any md files in the PR) |
DavertMik
reviewed
Dec 22, 2019
DavertMik
reviewed
Dec 22, 2019
- Add assertion to grabTextFrom Method - Remove assertion from grabTextFromAll Method
- Add grabAttributeFromAll - Add grabCssPropertyFromAll - Add grabValueFromAll - Add grabHTMLFromAll
|
Clones added
============
- lib/helper/Nightmare.js 2
- lib/helper/Protractor.js 6
- lib/helper/TestCafe.js 2
- lib/helper/WebDriver.js 7
- lib/helper/Puppeteer.js 6
See the complete overview on Codacy |
Vorobeyko
suggested changes
Dec 27, 2019
|
Should add GrabCss for nightmare helper too after ##2111 merges |
16 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Resolves #2093
Type of change
Checklist:
npm run docs)npm run lint)npm test)