Ignore variable declarations in JS (#250)

Author: brynary

lib/cc/engine/analyzers/javascript/main.rb

@@ -15,8 +15,8 @@ class Main < CC::Engine::Analyzers::Base
           DEFAULT_MASS_THRESHOLD = 45
           DEFAULT_FILTERS = [
             "(ImportDeclaration ___)".freeze,
+            "(VariableDeclarator _ (init (CallExpression (_ (Identifier require)) ___)))".freeze,
           ].freeze
-
           POINTS_PER_OVERAGE = 30_000
           REQUEST_PATH = "/javascript".freeze
 

spec/cc/engine/analyzers/javascript/main_spec.rb

@@ -122,24 +122,43 @@
     expect(issues.length).to eq 1
   end
 
-  it "ignores namespace and use declarations" do
-      create_source_file("foo.js", <<~EOJS)
-      import React, { Component, PropTypes } from 'react'
-      import { Table, TableBody, TableHeader, TableHeaderColumn, TableRow } from 'material-ui/Table'
-      import values from 'lodash/values'
-      import { v4 } from 'uuid'
-      EOJS
+  it "ignores imports" do
+    create_source_file("foo.js", <<~EOJS)
+    import React, { Component, PropTypes } from 'react'
+    import { Table, TableBody, TableHeader, TableHeaderColumn, TableRow } from 'material-ui/Table'
+    import values from 'lodash/values'
+    import { v4 } from 'uuid'
+    EOJS
+
+    create_source_file("bar.js", <<~EOJS)
+    import React, { Component, PropTypes } from 'react'
+    import { Table, TableBody, TableHeader, TableHeaderColumn, TableRow } from 'material-ui/Table'
+    import values from 'lodash/values'
+    import { v4 } from 'uuid'
+    EOJS
 
-      create_source_file("bar.js", <<~EOJS)
-      import React, { Component, PropTypes } from 'react'
-      import { Table, TableBody, TableHeader, TableHeaderColumn, TableRow } from 'material-ui/Table'
-      import values from 'lodash/values'
-      import { v4 } from 'uuid'
-      EOJS
+    issues = run_engine(engine_conf).strip.split("\0")
+    expect(issues).to be_empty
+  end
 
-      issues = run_engine(engine_conf).strip.split("\0")
-      expect(issues).to be_empty
-    end
+  it "ignores requires" do
+    create_source_file("foo.js", <<~EOJS)
+    const a = require('foo'),
+      b = require('bar'),
+      c = require('baz'),
+      d = require('bam');
+    EOJS
+
+    create_source_file("bar.js", <<~EOJS)
+    const a = require('foo'),
+      b = require('bar'),
+      c = require('baz'),
+      d = require('bam');
+    EOJS
+
+    issues = run_engine(engine_conf).strip.split("\0")
+    expect(issues).to be_empty
+  end
 
   def engine_conf
     CC::Engine::Analyzers::EngineConfig.new({