Alpine docker

[sysadmiral]

I've based the image on alpine to reduce the size of the image from ~800MB to ~300MB.

I've done some testing with the following repos:

• ruby - jekyll
• python - python-mysqltuner
• javascript - You-Dont-Need-Lodash-Underscore
• php - composer

Let me know if there are any issues with the Dockerfile/image.

Cheers,

Amo

[pbrisbin]

Using a latest tag runs the risk of non-reproducible builds as time goes on. Can you use the latest released tag, I think it's 3.4?

[sysadmiral]

updated! :)

[pbrisbin]

Ping @mrb do you remember the historical context around the JRuby choice here? It's unclear if we had a concrete performance issue that was addressed by moving to JRuby.

[pbrisbin]

I found the commit where we switched to JRuby: 4d34157 it includes some benchmarks for "a medium sized JavaScript project".

[sysadmiral]

I see. I did wonder about the decision since most other engines Dockerfiles used alpine.

If it would be better to continue with a larger but faster engine then this PR can be closed?

[pbrisbin]

If it would be better to continue with a larger but faster engine then this PR can be closed?

I'm not sure. We definitely appreciate your effort here, so we wanted to look into the performance implications before just closing the PR. That said, there may be a bit more effort involved in pinning down those performance questions, and living with the larger image is not a problem for us.

So, if you're willing to work on getting some performance metrics on various projects (especially larger ones) we'd be happy to evaluate that and (if the performance loss isn't great) work towards merging this. If you'd rather not though, we'll stick with the larger JRuby image for now.

[sysadmiral]

I'd be happy to compare analysis results on a set of repos (top 50 trending repos on github?) but do I get the timings just using the --dev flag?

[pbrisbin]

I think I would use this approach:

• Build an image from master with a tag (e.g. :jruby)
• Build an image from this branch with another tag (e.g. :alpine)
• In each example project:
• Tag the jruby image as codeclimate/codeclimate-duplication
• Run time codeclimate analyze -e duplication
• Tag the alpine image as codeclimate/codeclimate-duplication
• Run time codeclimate analyze -e duplication

[sysadmiral]

Great I will come back here when I have more information. Thanks for the help! 😄

[dblandin]

Hey @sysadmiral,

Just checking in. :) Any update on this PR?

[sysadmiral]

Sorry not yet. I should have time next week though to get some of this done. Would that be ok?

[dblandin]

Sorry not yet. I should have time next week though to get some of this done. Would that be ok?

For sure! Ping us when you're ready for another review. Thanks!

[dblandin]

Hey @sysadmiral! Any interest in finishing this up? If not, no worries. We can revisit this at a later time.

[sysadmiral]

Hi @dblandin definitely got the interest just struggling to get the time right now.

I'm happy for you to close this if it helps your "housekeeping" but if you are ok to leave it open for me to work on it that would be great.

Let me know what works best for you.

[dblandin]

Going to go ahead and close this PR for now. Feel free to reopen later!