Analyze files with .es6 extensions by default #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will es6 parse correctly without the babel parser? We defaulted to babel for a while but backed off of that due to errors |
|
@gordondiggs Ah okay, maybe not. Looks like Esprima is starting to support es6 and has an experimental Harmony branch but perhaps is not all the way there. I'll go ahead and close this PR for now. Can revisit later. Thanks for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should also analyze .es6 file extensions by default.
This creates an easier setup for users with
.es6filesI don't believe there's anything special about the syntax to be avoided, but glad to be corrected if not the case.
cc @codeclimate/review