Add Symfony2 coding standard #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblandin
approved these changes
Apr 4, 2017
|
Nice. Thanks! |
|
@pointlessone Do we need any remediation point overrides for any checks in this standard? https://github.com/codeclimate/codeclimate-phpcodesniffer/blob/master/Sniffs.php#L13 |
|
@dblandin I don't know. How does one estimate that? |
|
I took a quick look at the sniffs included and I don't think any need an override. We would specific a greater value if an issue requires more time to fix, like a duplication or complexity issue. |
|
This engine defaults to 70k which is already greater that 50k default in the spec. |
|
Yeah, I don't know why this engine has a different default. Something to fix. |
|
I can't find this standard anywhere in the documentation. How do I configure it? Is it called 'Symfony', 'Symfony2', something else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #57.