This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Update GitHub status description for skipped builds #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| elsif config.update_status | ||
| update_status_success | ||
| elsif config.add_comment | ||
| add_comment |
There was a problem hiding this comment.
My spidey sense is tingling about this change around config.add_comment.
Are there any conditions where we want to call add_comment and not call update_status_success -- /cc @noahd1 @jonathancadepowers
https://trello.com/c/q3ByzTqY When analysis for a commit is skipped because a newer commit was pushed to the branch, we want to set the status to "success" so that it isn't stuck in a yellow "pending" state, but we also want to indicate that analysis didn't run on the skipped commit. So we differentiate the skipped case with a different status message. Also, never add a comment for a commit that we have skipped, regardless of the config settings.
mrgilman
force-pushed
the
mg-ia-skipped-status-message
branch
from
bf47706 to
206107d
Compare
|
/cc @codeclimate/review this is ready for a re-review after making this PR compatible with the changes that went in master from #56 |
|
|
iancanderson
added a commit
that referenced
this pull request
Mar 17, 2015
Update GitHub status description for skipped builds
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/q3ByzTqY
When analysis for a commit is skipped because a newer commit was pushed
to the branch, we want to set the status to "success" so that it isn't
stuck in a yellow "pending" state, but we also want to indicate that
analysis didn't run on the skipped commit. So we differentiate the
skipped case with a different status message. Also, never add a comment
for a commit that we have skipped, regardless of the config settings.