This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Give an OK of false if the PR comment exists #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| def add_comment | ||
| if config.add_comment && !comment_present? |
There was a problem hiding this comment.
Why was the add_comment check removed?
There was a problem hiding this comment.
We are actually relying on these checks to be here (and in #update_status) in our other PR 😄 #55
There was a problem hiding this comment.
@marshally Because the check actually happens here: https://github.com/codeclimate/codeclimate-services/blob/jy-do-not-allow-nil-branches/lib/cc/services/github_pull_requests.rb#L53 and this check only served to muddy the waters about what was happening.
Add a middleware that should be placed at the bottom of the Invocation stack. This middleware ensures that any time the invocation stack is called, there is a return value. If the stack comes back nil, then a message is put in its place implying an error. While this might not technically be the case that the service errored, a lack of return value should be considered an error and looked in to.
|
Talked with @marshally on the phone. He gives a |
by proxy.
jyurek
pushed a commit
that referenced
this pull request
Mar 17, 2015
Give an OK of false if the PR comment exists
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.