CodeClimate::TestReporter::InvalidPayload on Rails dummy app

[antek-drzewiecki]

Hi,

I am using CodeClimate to test my gem with that contains a Rails dummy app in my spec/ directory.
Since CodeClimate version 0.4.4 my specs exit with an CodeClimate::TestReporter::InvalidPayload 'A git commit timestamp was not found in the test report payload' error.

Stacktrace

fatal: Not a git repository: 'dir/wine_bouncer/spec/dummy/.git'
Code Climate encountered an exception: CodeClimate::TestReporter::InvalidPayload
A git commit timestamp was not found in the test report payload
rvmgemdir/codeclimate-test-reporter-0.4.4/lib/code_climate/test_reporter/payload_validator.rb:16:in `validate'
rvmgemdir/codeclimate-test-reporter-0.4.4/lib/code_climate/test_reporter/payload_validator.rb:11:in `validate'
rvmgemdir/codeclimate-test-reporter-0.4.4/lib/code_climate/test_reporter/formatter.rb:21:in `format'
rvmgemdir/simplecov-0.9.1/lib/simplecov/result.rb:46:in `format!'
rvmgemdir/simplecov-0.9.1/lib/simplecov/configuration.rb:158:in `block in at_exit'
rvmgemdir/simplecov-0.9.1/lib/simplecov/defaults.rb:54:in `call'
rvmgemdir/simplecov-0.9.1/lib/simplecov/defaults.rb:54:in `block in <top (required)>'

What is probably happening

I have a gem git repository on dir/wine_bouncer/.git and an dummy app on dir/wine_bouncer/spec/dummy/.git. I am running my specs from the gem root directory. Since my specs use a mounted dummy app for integration testing, ruby-test-preporter assumes the .git directory is inside the specs directory.

This is probably because the Rails module is defined upon exiting. And is probably introduced by the #63 PR on the git_dir method.

This issue both occurs on Travis-ci and console when having a Rails dummy app mounted in your gem.

[antek-drzewiecki]

@Strech do you have any suggestions how we can fix this issue it also accepts Rails dummy apps?
I don't think checking if the Rails.root output contains specs directory is the right way to go.
Will changing Rails.root to Dir.pwd solve the issue?

[Strech]

@antek-drzewiecki in my case Dir.pwd return /tmp/ folder. I think we can try to find out place of .git, looking for popular places, like pwd and rails root

[craiglittle]

Hey there!

FWIW, I'm experiencing the same issue for what appear to be similar reasons. Looks like there are others out there as well.

[calavera]

oh, this is interesting. So, Rails is defined, but it's for the app that you're using as a stub. We might need to pre calculate the path to the git directory before we do any of these calls.

[Strech]

@calavera I can add .git directory existing checks, before select concrete folder

[NullVoxPopuli]

Is there a version of ruby-test-reporter that doesn't have this problem? I'd like to have coverage tracked for my gem: https://github.com/NullVoxPopuli/authorizable :-)

[calavera]

@NullVoxPopuli yeah, you can point your Gemfile to the previous version while we investigate this:

https://rubygems.org/gems/codeclimate-test-reporter/versions/0.4.3

[NullVoxPopuli]

thanks!

[calavera]

I just opened #65 with a fix. @antek-drzewiecki, @craiglittle, @NullVoxPopuli do you mind to test that the change fixes your issue? It should be a small change in your Gemfile until it's merged and released:

gem "codeclimate-test-reporter", git: "https://github.com/codeclimate/ruby-test-reporter.git", branch: "check_git_dir"

[Strech]

@calavera For my case your branch says Sending report to https://codeclimate.com for branch master... done. So, this solve my problem too 👍

[calavera]

cool, I'm going to wait for some other confirmation before merging, but expect a new release tomorrow morning. 🎉

[NullVoxPopuli]

@calavera my results:

from bundle install:
Using codeclimate-test-reporter 0.4.4 (was 0.4.3) from https://github.com/codeclimate/ruby-test-reporter.git (at check_git_dir)

after running rspec:

Coverage = 89.71%. fatal: Not a git repository: '/home/me/Development/authorizable/spec/support/rails_app/.git'
fatal: Not a git repository: '/home/me/Development/authorizable/spec/support/rails_app/.git'
fatal: Not a git repository: '/home/me/Development/authorizable/spec/support/rails_app/.git'

Gemfile:

source 'https://rubygems.org'

# Specify your gem's dependencies in authorizable.gemspec
gemspec

gem "codeclimate-test-reporter", git: "https://github.com/codeclimate/ruby-test-reporter.git", branch: "check_git_dir"

[calavera]

thanks @NullVoxPopuli. I'm cloning your gem to reproduce the issue.