This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Respect SSL_CERT_FILE environment variable #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manveru can you fix up the Code Climate issues here? I can merge and release when it is green! |
| @@ -13,6 +13,11 @@ def host | |||
| ENV["CODECLIMATE_API_HOST"] || | |||
| "https://codeclimate.com" | |||
| end | |||
|
|
|||
| def ca_file | |||
There was a problem hiding this comment.
Can you make this method private?
There was a problem hiding this comment.
should #host be private too then?
There was a problem hiding this comment.
I think host is called externally. I don't see this one needing to be called from outside the class, though
|
@gordondiggs all done :) |
|
@manveru if you update to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important when you self-host CodeClimate and use your own certificate. The one in the repo is over 3 years old and can't cover all self-signed certificates either.