This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Force UTF-8 to calculate blob ids. #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to be wary about forcing encoding for reading. The encoding is by default UTF-8 and only causes an error when trying to read an invalid sequence of UTF-8. My main concern here is: If we force the encoding from read, what happens to the replaced/ignored bytes and do they affect the blob_id calculation? |
calavera
added a commit
that referenced
this pull request
Sep 27, 2014
Force UTF-8 to calculate blob ids.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix issues when people send reports without properly specifying their encoding.