This repository was archived by the owner on Jul 19, 2025. It is now read-only.
cleanup + tests #79
Merged
cleanup + tests #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ENV['CODECLIMATE_REPO_TOKEN'] = "172754c1bf9a3c698f7770b9fb648f1ebb214425120022d0b2ffc65b97dff531" | ||
| ENV['CODECLIMATE_API_HOST'] = "http://cc.dev" | ||
|
|
||
| def inflate(string) |
There was a problem hiding this comment.
this was global -> putting it into just tests
|
@calavera good to go ? |
|
@calavera can you merge this ? |
|
@calavera ping |
|
@calavera can this get merged ? |
|
Sorry I don't have privileges to merge PRs in this repo anymore. /cc @noahd1 |
|
ahh thanks, @noahd1 can you review this please ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@calavera
using webmock since it has the nice sideeffect of blowing up when a request is done by accident
also we no longer need to declare a custom rack endpoint :)
dropping rubygems requires since they are not needed on 1.9+
adding test for untested batch_post_results