This repository was archived by the owner on Jul 19, 2025. It is now read-only.
log message when sending coverage report #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agree. Can you add that to this PR? |
fredrik
force-pushed
the
log-not-reporting-as-debug
branch
from
e382ee8 to
5da7dab
Compare
|
I've made that change, @noahd1. 👍 |
| unless @environment_variable_set | ||
| logger.info("Not reporting to Code Climate because ENV['CODECLIMATE_REPO_TOKEN'] is not set.") | ||
| if @environment_variable_set | ||
| logger.debug("Reporting coverage data to Code Climate.") |
There was a problem hiding this comment.
It's helpful to print this on info level, so that we can see when customers write in with issues if the environment variable was set.
fredrik
force-pushed
the
log-not-reporting-as-debug
branch
from
5da7dab to
4e11a46
Compare
fredrik
changed the title
noahd1
added a commit
that referenced
this pull request
Apr 24, 2015
…debug log message when sending coverage report
|
Thanks for your contribution! |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This message isn't very useful to see on every test run so I'd rather 'hide' it at the debug log level or drop the log message completely.
In fact, perhaps it makes more sense to log a message when
CODECLIMATE_REPO_TOKENis set?