Moving thing in my-app to root folder. #52
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProsperousHeart
added
bug / defect
ProsperousHeart
requested changes
Jun 8, 2023
jhoover4
commented
Jun 8, 2023
|
To avoid the back and forth and to ensure a clean branch for volunteers moving forward (plus provide other updates needed) we will now be closing this PR to #53. Once it is merged, one of the core admin team members will comment on #49 so you can pull updates from the v1-MVP branch and push back up to #49. Thank you for your patience and insight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving things from
my-appto root of project.We're doing this because a proper app setup for a single react app in a repo should have
srcas a top level folder andpackage.jsonin the root.