-
Notifications
You must be signed in to change notification settings - Fork 9
app move + minor updates #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.gitignore
Outdated
/build | ||
|
||
# misc | ||
.DS_Store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all below already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .DS_Store
was but not the /build
- only a specific sub folder of it.
/coverage | ||
|
||
# production | ||
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep this the rest are repeats I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left the items from original .gitignore for a reason - hence the commented line for pre-2023. Those were things from the prior project that we may re-use. There is no issue with leaving them as is. Feel free to inquire about this in Discord for discussion with the rest of the Core Team Admins and other volunteers.
I did miss a few of the duplicates, so thank you for that. Resolving them directly in the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You want to remove them because it might cause issues like we did today. I feel like if you need them later you can just add them then?
Removing duplicates as reviewed by @jhoover4
.gitignore
so that the public folder would be publishedResolves #50