Skip to content

Conversation

ProsperousHeart
Copy link
Member

@ProsperousHeart ProsperousHeart commented Jun 8, 2023

  • updated .gitignore so that the public folder would be published
  • moved files and folders to ensure all data uploaded (after confirmation of testing)
  • documentation updates

Resolves #50

@ProsperousHeart ProsperousHeart added enhancement Not a requirement - enhances or improves project documentation Update to documentation requirements good first issue labels Jun 8, 2023
@ProsperousHeart ProsperousHeart linked an issue Jun 8, 2023 that may be closed by this pull request
@ProsperousHeart ProsperousHeart added the bug / defect A bug was found in a branch and needs to be addressed. label Jun 8, 2023
.gitignore Outdated
/build

# misc
.DS_Store
Copy link

@jhoover4 jhoover4 Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all below already

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .DS_Store was but not the /build - only a specific sub folder of it.

/coverage

# production
/build
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep this the rest are repeats I think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the items from original .gitignore for a reason - hence the commented line for pre-2023. Those were things from the prior project that we may re-use. There is no issue with leaving them as is. Feel free to inquire about this in Discord for discussion with the rest of the Core Team Admins and other volunteers.

I did miss a few of the duplicates, so thank you for that. Resolving them directly in the PR.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to remove them because it might cause issues like we did today. I feel like if you need them later you can just add them then?

Removing duplicates as reviewed by @jhoover4
@RobinHerzig RobinHerzig merged commit 8e711c2 into codefordallas:v1-mvp Jun 9, 2023
This was referenced Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / defect A bug was found in a branch and needs to be addressed. documentation Update to documentation enhancement Not a requirement - enhances or improves project good first issue requirements
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

move app from folder to main
3 participants