Skip to content

Commit 9227f37

Browse files
rename warning handler to warn. this is the standard by cf-logs lib
1 parent f870679 commit 9227f37

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "cf-common",
3-
"version": "0.0.23",
3+
"version": "0.0.24",
44
"description": "common modules for codefresh runtime and api",
55
"main": "index.js",
66
"scripts": {

taskLogger/taskLogger.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ var TaskLogger = function (jobId, firstStepCreationTime, baseFirebaseUrl, Fireba
8787
},
8888
debug: function () {
8989
},
90-
warning: function () {
90+
warn: function () {
9191
},
9292
info: function () {
9393
},
@@ -155,7 +155,7 @@ var TaskLogger = function (jobId, firstStepCreationTime, baseFirebaseUrl, Fireba
155155
self.emit("error", new CFError(ErrorTypes.Error, "progress-logs 'debug' handler was triggered after the job finished with message: %s", message));
156156
}
157157
},
158-
warning: function (message) {
158+
warn: function (message) {
159159
if (fatal) return;
160160
if (step.status === "running") {
161161
step.hasWarning = true;

taskLogger/taskLogger.unit.spec.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ describe('taskLogger tests', function () {
120120
var stepLogger = logger.create("step1");
121121
expect(stepLogger.write()).to.equal(undefined);
122122
expect(stepLogger.debug()).to.equal(undefined);
123-
expect(stepLogger.warning()).to.equal(undefined);
123+
expect(stepLogger.warn()).to.equal(undefined);
124124
expect(stepLogger.info()).to.equal(undefined);
125125
expect(stepLogger.finish()).to.equal(undefined);
126126
});
@@ -140,7 +140,7 @@ describe('taskLogger tests', function () {
140140
var stepLogger = logger.create("step1");
141141
expect(stepLogger.write()).to.equal(undefined);
142142
expect(stepLogger.debug()).to.equal(undefined);
143-
expect(stepLogger.warning()).to.equal(undefined);
143+
expect(stepLogger.warn()).to.equal(undefined);
144144
expect(stepLogger.info()).to.equal(undefined);
145145
expect(stepLogger.finish()).to.equal(undefined);
146146
});
@@ -228,7 +228,7 @@ describe('taskLogger tests', function () {
228228
expect(stepLogger).to.exist; // jshint ignore:line
229229
expect(stepLogger.write).to.exist; // jshint ignore:line
230230
expect(stepLogger.debug).to.exist; // jshint ignore:line
231-
expect(stepLogger.warning).to.exist; // jshint ignore:line
231+
expect(stepLogger.warn).to.exist; // jshint ignore:line
232232
expect(stepLogger.info).to.exist; // jshint ignore:line
233233
expect(stepLogger.finish).to.exist; // jshint ignore:line
234234
expect(removeSpy).to.not.have.been.called; // jshint ignore:line
@@ -242,7 +242,7 @@ describe('taskLogger tests', function () {
242242
expect(stepLogger).to.exist; // jshint ignore:line
243243
expect(stepLogger.write).to.exist; // jshint ignore:line
244244
expect(stepLogger.debug).to.exist; // jshint ignore:line
245-
expect(stepLogger.warning).to.exist; // jshint ignore:line
245+
expect(stepLogger.warn).to.exist; // jshint ignore:line
246246
expect(stepLogger.info).to.exist; // jshint ignore:line
247247
expect(stepLogger.finish).to.exist; // jshint ignore:line
248248
logger.create("step1");
@@ -256,7 +256,7 @@ describe('taskLogger tests', function () {
256256
expect(stepLogger).to.exist; // jshint ignore:line
257257
expect(stepLogger.write).to.exist; // jshint ignore:line
258258
expect(stepLogger.debug).to.exist; // jshint ignore:line
259-
expect(stepLogger.warning).to.exist; // jshint ignore:line
259+
expect(stepLogger.warn).to.exist; // jshint ignore:line
260260
expect(stepLogger.info).to.exist; // jshint ignore:line
261261
expect(stepLogger.finish).to.exist; // jshint ignore:line
262262
logger.create("step1");
@@ -331,13 +331,13 @@ describe('taskLogger tests', function () {
331331

332332
});
333333

334-
it('3.3 trigger warning handler', function(){
334+
it('3.3 trigger warn handler', function(){
335335

336336
var Firebase = createMockFirebase();
337337
var Logger = createMockLogger();
338338
var logger = new Logger("progress_id", null, "firebaseUrl", Firebase, {servers: ['address']});
339339
var stepLogger = logger.create("step1");
340-
stepLogger.warning("warning message");
340+
stepLogger.warn("warn message");
341341

342342
});
343343

@@ -371,13 +371,13 @@ describe('taskLogger tests', function () {
371371

372372
});
373373

374-
it('3.7 trigger warning handler and finish', function(){
374+
it('3.7 trigger warn handler and finish', function(){
375375

376376
var Firebase = createMockFirebase();
377377
var Logger = createMockLogger();
378378
var logger = new Logger("progress_id", null, "firebaseUrl", Firebase, {servers: ['address']});
379379
var stepLogger = logger.create("step1");
380-
stepLogger.warning("warning message");
380+
stepLogger.warn("warn message");
381381
stepLogger.finish();
382382

383383
});
@@ -421,7 +421,7 @@ describe('taskLogger tests', function () {
421421
stepLogger.debug("not good!");
422422
});
423423

424-
it('4.3 should emit an error when triggering warning handler after step has finished', function(done){
424+
it('4.3 should emit an error when triggering warn handler after step has finished', function(done){
425425
var Firebase = createMockFirebase();
426426
var Logger = createMockLogger();
427427
var logger = new Logger("progress_id", null, "firebaseUrl", Firebase, {servers: ['address']});
@@ -431,7 +431,7 @@ describe('taskLogger tests', function () {
431431
done();
432432
});
433433
stepLogger.finish();
434-
stepLogger.warning("not good!");
434+
stepLogger.warn("not good!");
435435
});
436436

437437
it('4.4 should emit an error when triggering info handler after step has finished', function(done){

0 commit comments

Comments
 (0)