fix handeling injection on non strings

Author: itai-codefresh

lib/transformers/DockerCompose.js

@@ -259,7 +259,12 @@ var injectVarsToObject = function(object, vars) {
                 else {
                     var field = object[property];
                     var replaceWith = _.find(vars, function(v){ // jshint ignore:line
-                        return field.includes(v.key);
+                        if (typeof field === 'string' || field instanceof String){
+                            return field.includes(v.key);
+                        }
+                        else {
+                            return false;
+                        }
                     });
                     if (replaceWith){
                         object[property] = object[property].replace(replaceWith.key, replaceWith.value);

test/config/field_not_string.yml

@@ -0,0 +1,6 @@
+version: '2'
+services:
+    image: codefresh/cf-runtime:develop
+    privileged: true
+
+

test/tests.unit.spec.js

@@ -252,6 +252,18 @@ var tests_docker_compose = [
                 }
             }
         }
+    },
+    {
+        name: 'field_not_string',
+        file: 'config/field_not_string.yml',
+        compositionVars: [{key: 'key', value: 'value'}],
+        expected: {
+            "version": "2",
+            "services": {
+                "image": "codefresh/cf-runtime:develop",
+                "privileged": true
+            }
+        }
     }
 ];
 describe("Transform composition", function () {
@@ -264,7 +276,8 @@ describe("Transform composition", function () {
 
                 var transformer = new Transformer({
                     file: path.join(__dirname, test.file),
-                    handlers: test.handlers
+                    handlers: test.handlers,
+                    compositionVars: test.compositionVars || []
                 });
 
                 transformer.fileToCompose()