Merge pull request #6198 from kenjis/fix-dynamic-property-in-BaseConnection

fix: BaseConnection may create dynamic property

Author: kenjis

system/Database/BaseConnection.php

@@ -336,7 +336,9 @@ abstract class BaseConnection implements ConnectionInterface
     public function __construct(array $params)
     {
         foreach ($params as $key => $value) {
-            $this->{$key} = $value;
+            if (property_exists($this, $key)) {
+                $this->{$key} = $value;
+            }
         }
 
         $queryClass = str_replace('Connection', 'Query', static::class);

system/Database/Postgre/Connection.php

@@ -42,6 +42,11 @@ class Connection extends BaseConnection
      */
     public $escapeChar = '"';
 
+    protected $connect_timeout;
+    protected $options;
+    protected $sslmode;
+    protected $service;
+
     /**
      * Connect to the database.
      *

system/Test/Mock/MockConnection.php

@@ -19,6 +19,14 @@
 class MockConnection extends BaseConnection
 {
     protected $returnValues = [];
+
+    /**
+     * Database schema for Postgre and SQLSRV
+     *
+     * @var string
+     */
+    protected $schema;
+
     public $database;
     public $lastQuery;