feat: setter/getter must be public

This will allow developers to implement `protected function setRelation()`
 without accidentally triggering on `$entity->relation = $value`.

Author: kenjis

system/Entity/Entity.php

@@ -29,6 +29,7 @@
 use DateTime;
 use Exception;
 use JsonSerializable;
+use ReflectionMethod;
 use ReturnTypeWillChange;
 
 /**
@@ -461,7 +462,7 @@ public function __set(string $key, $value = null)
         // so maybe wants to do sth with null value automatically
         $method = 'set' . str_replace(' ', '', ucwords(str_replace(['-', '_'], ' ', $key)));
 
-        if (method_exists($this, $method) && $method !== 'setAttributes') {
+        if (method_exists($this, $method) && $method !== 'setAttributes' && $this->isPublic($method)) {
             $this->{$method}($value);
 
             return $this;
@@ -476,6 +477,13 @@ public function __set(string $key, $value = null)
         return $this;
     }
 
+    private function isPublic(string $method): bool
+    {
+        $reflection = new ReflectionMethod($this, $method);
+
+        return $reflection->isPublic();
+    }
+
     /**
      * Magic method to allow retrieval of protected and private class properties
      * either by their name, or through a `getCamelCasedProperty()` method.
@@ -501,7 +509,7 @@ public function __get(string $key)
 
         // if a get* method exists for this key,
         // use that method to insert this value.
-        if (method_exists($this, $method)) {
+        if (method_exists($this, $method) && $this->isPublic($method)) {
             $result = $this->{$method}();
         }
 

tests/system/Entity/EntityTest.php

@@ -1114,12 +1114,12 @@ protected function getMappedEntity()
                 'orig' => 'simple',
             ];
 
-            protected function setSimple(string $val)
+            public function setSimple(string $val)
             {
                 $this->attributes['simple'] = 'oo:' . $val;
             }
 
-            protected function getSimple()
+            public function getSimple()
             {
                 return $this->attributes['simple'] . ':oo';
             }