Skip to content

Conversation

paulbalandan
Copy link
Member

Description
Fixes #9265
Replaces and closes #9280

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan
Copy link
Member Author

The test is useless because (1) in PHP, arrays with duplicate keys always retains the last key, and (2) CURLRequest::parseOptions() only checks for baseURI key not base_uri.

@ddevsr ddevsr added the refactor Pull requests that refactor code label Dec 1, 2024
@paulbalandan paulbalandan merged commit 4c8b782 into codeigniter4:develop Dec 1, 2024
41 checks passed
@paulbalandan paulbalandan deleted the curl-base-uri branch December 1, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: base_uri or baseURI in curlrequest?

3 participants