Skip to content

fix: baseURI for curlrequest and image/jpg for jpg mime #9280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: baseURI for curlrequest and image/jpg for jpg mime #9280

wants to merge 1 commit into from

Conversation

warmbook
Copy link

@warmbook warmbook commented Nov 15, 2024 •
edited
Loading

#9265
Description
Use 'baseURI' instead of 'base_uri' as the manual described.
Add 'image/jpg' mime for file extension jpg.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@warmbook warmbook changed the title baseURI for curlrequest and image/jpg for jpg mime fix: baseURI for curlrequest and image/jpg for jpg mime Nov 15, 2024
neznaika0
neznaika0 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@neznaika0 neznaika0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your desire for improvement.
It is recommended to divide PR by meaning. The first change refers to CURL, the second to Config. This is for you in the future

@michalsn
Copy link
Member

One "issue" one PR, please.

@warmbook
Copy link
Author

One "issue" one PR, please.

Sorry! I forgot it.

@ddevsr
Copy link
Collaborator

ddevsr commented Nov 16, 2024 •
edited
Loading

Rework test in CURL with base_uri to baseURI?

@michalsn michalsn added the needs rework Changes requested by reviewer that are still pending label Nov 17, 2024
@paulbalandan paulbalandan mentioned this pull request Nov 30, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@neznaika0 neznaika0 neznaika0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs rework Changes requested by reviewer that are still pending

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@warmbook @michalsn @ddevsr @neznaika0