Add User State in Authenticators\Session #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonnieezell
requested changes
May 17, 2022
| return $this->user instanceof User; | ||
| $identities = $this->userIdentityModel->getIdentitiesByTypes( | ||
| $this->user->getAuthId(), | ||
| ['email_2fa', 'email_activate'] |
There was a problem hiding this comment.
I think you need to get the list of actions assigned in the config file here, otherwise if some wants to do, says, 2FA with SMS messages, this logic would be skipped.
There was a problem hiding this comment.
I removed the hard coded action types.
kenjis
force-pushed
the
refactor-pending-login
branch
from
c2a6bb9 to
9c81dba
Compare
MGatner
reviewed
May 17, 2022
|
I believe this PR can now be merged. One more refactoring would make the code more readable. |
…e() in Authenticators\Session
The user id stored in session is not only of logged-in, but also of pending login.
…dential check passes
The pending login state is determined by whether or not the identitiy is stored in the DB. It is not sufficient to save the auth_action in the session after registration. If the redirect to the action page is aborted, Email Activation can be avoided.
kenjis
force-pushed
the
refactor-pending-login
branch
from
91ecb64 to
44f1deb
Compare
lonnieezell
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$userStateinSessionSession::loggedIn()does not returntruefor pending login user.Session::getUser()does not return pending login user, soauth()->user()also does not return.Session::getPendingUser()Session::isPending()that returnstruewhen a user is in pending login state.Session::isAnonymous()ActionInterface::getType()