Skip to content

Conversation

parisiam
Copy link
Contributor

Fixes #294

  • Prevents a logged in user to register
  • A corresponding unit test was added

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get the same on registerAction()?

@parisiam
Copy link
Contributor Author

Yes, sure, happy to help ;)
I've submitted the changes for registerAction() and for the tests.
Please check the tests (I may have be redundant or incomplete).

@kenjis
Copy link
Member

kenjis commented Jul 16, 2022

What if a user is pending login state (in the process of 2FA)?
See #132

@MGatner
Copy link
Member

MGatner commented Jul 17, 2022

I think that's fine. They may have mistyped their email address, or want multiple accounts. In my opinion this is mostly about preventing confusion, rather than a security or behavior issue.

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks!

@kenjis kenjis merged commit d2aff61 into codeigniter4:develop Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registration form still accessible when user is logged in
3 participants