Skip to content
This repository was archived by the owner on Apr 13, 2025. It is now read-only.

Conversation

hlxid
Copy link
Member

@hlxid hlxid commented Nov 19, 2021

No description provided.

Instead of using the external `gunzip-maybe` dependency for extracting the gzipped npm packages we can use `zlib` which is integrated in node.js and we have one less dependency.
Refer to codeoverflow-org/nodecg-io#239 for more information about `nodecg-types`. This PR updates the generation logic to generate bundles depending on `nodecg-types` instead of `nodecg` for typings when generating a TypeScript bundle.
Currently we're using [find-up](https://www.npmjs.com/package/find-up) to traverse the filesystem and find the nodecg installation if the user is an subdirectory like `bundles/`.
To reduce our dependencies we can simply implement this ourselfs. I can't remember why I used `find-up` in the first place as using it is almost harder than implementing it directly, lol.
* feat: add support for nodecg-io 0.2

* Fix test compile errors due to unchecked array access
@hlxid hlxid merged commit 77f4c26 into main Nov 19, 2021
@hlxid hlxid deleted the next branch November 19, 2021 19:20
@github-actions
Copy link

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant