fix: Continue attempting connections no matter what (#412)

* fix: Continue accepting connections after yamux session EOFs

* Add verbosity to timeout

* Revert test

* Revert test change

* Never exit when connection fails

* Remove useless log

Author: kylecarbs

internal/cmd/agent.go

@@ -84,6 +84,7 @@ coder agent start --coder-url https://my-coder.com --token xxxx-xxxx
 				return xerrors.Errorf("listen: %w", err)
 			}
 			defer func() {
+				log.Info(ctx, "closing wsnet listener")
 				err := listener.Close()
 				if err != nil {
 					log.Error(ctx, "close listener", slog.Error(err))

wsnet/listen.go

@@ -71,7 +71,7 @@ func Listen(ctx context.Context, log slog.Logger, broker string, turnProxyAuthTo
 			default:
 			}
 
-			if errors.Is(err, io.EOF) || errors.Is(err, yamux.ErrKeepAliveTimeout) {
+			if err != nil {
 				l.log.Warn(ctx, "disconnected from broker", slog.Error(err))
 
 				// If we hit an EOF, then the connection to the broker
@@ -88,14 +88,11 @@ func Listen(ctx context.Context, log slog.Logger, broker string, turnProxyAuthTo
 					if err == nil || errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded) {
 						break
 					}
+					l.log.Warn(ctx, "connecting to broker failed", slog.Error(err))
 				}
 				ticker.Stop()
 			}
-			if err != nil {
-				l.acceptError = err
-				_ = l.Close()
-				break
-			}
+			l.log.Info(ctx, "connected to broker")
 		}
 	}()
 	return l, nil
@@ -106,7 +103,6 @@ type listener struct {
 	turnProxyAuthToken string
 
 	log            slog.Logger
-	acceptError    error
 	ws             *websocket.Conn
 	connClosers    []io.Closer
 	connClosersMut sync.Mutex