Editing a file in the template editor removes the executable bit from other files (e.g. scripts)

[mafredri]

I have a template with a bunch of .sh files that have the executable bit set (chmod +x *.sh). If I edit a file in the template editor (Web UI), all the .sh files lose their executable bit (chmod -x *.sh).

We should keep the executable bit when making changes in the Web UI.

[BrunoQuaresma]

How can I reproduce that and test if the fix is working?

[mafredri]

@BrunoQuaresma

1. Create a template/folder with a script file (doesn't need to be references in tf and can be empty):

# ls my-template/
main.tf
script.sh

2. Then make it executable and push it

chmod +x my-template/script.sh

ls -l my-template/script.sh
-rwxr-xr-x ... my-template/script.sh

coder templates push -d ./my-template

3. Edit main.tf in the web editor (I believe this will suffice, otherwise you can try editing script.sh too)

4. Pull the template coder templates pull my-template and examine script.sh via ls -l again, it should still have the x (eXecutable bit) in -rwxr-xr-x, but it doesn't.

[BrunoQuaresma]

@mafredri I think it was fixed by #12000 can you please do a double check? 🙏

[mafredri]

@BrunoQuaresma indeed, it seems to be fixed, thanks!