fix(site): watch build logs while job is pending or running #15341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
ethanndickson
force-pushed
the
ethan/insta-fail-logs-fix
branch
3 times, most recently
from
8910f3b to
37f1016
Compare
ethanndickson
commented
Nov 4, 2024
| calls += 1; | ||
| return HttpResponse.json( | ||
| calls > 1 ? MockRunningTemplateVersion : MockPendingTemplateVersion, | ||
| running ? MockRunningTemplateVersion : MockPendingTemplateVersion, |
There was a problem hiding this comment.
This test was failing because as we end up querying versions/{id} an extra time with this change. I think we should just manually update the status instead of relying on a specific number of api calls.
There was a problem hiding this comment.
Can you please leave a comment in the code about why we are using running? I can see my self not remembering this in two months.
ethanndickson
force-pushed
the
ethan/insta-fail-logs-fix
branch
from
37f1016 to
9a2fc63
Compare
ethanndickson
changed the title
ethanndickson
force-pushed
the
ethan/insta-fail-logs-fix
branch
from
9a2fc63 to
c8662c6
Compare
BrunoQuaresma
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15292.
Currently, if the frontend never sees a build job enter 'running', it'll never end up watching the logs. If we start watching the logs earlier we're able to catch cases where the job goes
pending->failed, such as when the build fails immediately.