feat: Prevent role changing on yourself. #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only allow changing roles on other users. Not much value in self changing at the moment
kylecarbs
approved these changes
May 31, 2022
f0ssel
approved these changes
May 31, 2022
| @@ -445,7 +445,7 @@ func TestGrantRoles(t *testing.T) { | |||
| require.Error(t, err, "member cannot change other's roles") | |||
| requireStatusCode(t, err, http.StatusForbidden) | |||
|
|
|||
| _, err = member.UpdateUserRoles(ctx, memberUser.ID.String(), codersdk.UpdateRoles{ | |||
| _, err = member.UpdateUserRoles(ctx, first.UserID.String(), codersdk.UpdateRoles{ | |||
| Roles: []string{rbac.RoleMember()}, | |||
| }) | |||
| require.Error(t, err, "member cannot change any roles") | |||
There was a problem hiding this comment.
This should reference "changing their own role" in the error or test name.
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* feat: Prevent role changing on yourself. Only allow changing roles on other users. Not much value in self changing at the moment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only allow changing roles on other users. Not much value in self changing
at the moment
#1847
Future Work
Update UI error
Response payload
{"message":"You cannot change your own roles."}