ci: restrict benchmark workflow to bench/ branches only #77
Conversation
Only run benchmarks on bench/ prefixed branches or manual workflow dispatch to avoid running expensive benchmarks on all PRs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - 'bench/**' | ||
| pull_request: | ||
| branches: [main] | ||
| paths: | ||
| - 'src/rules/**' | ||
| - 'benches/**' | ||
| - '.github/workflows/benchmark.yml' | ||
| branches: | ||
| - 'bench/**' |
There was a problem hiding this comment.
The new trigger filters pull_request.branches to bench/**, but on GitHub Actions this key matches the base branch, not the source branch. Typical benchmark PRs will target main from branches like bench/foo, so this workflow will never trigger for those PRs. The change therefore disables benchmark runs for the very branches it is meant to cover. Consider keeping branches: [main] and adding an if: startsWith(github.head_ref, 'bench/') or a similar condition to gate on the PR’s head branch instead.
Useful? React with 👍 / 👎.
Summary
bench/**branches or manual workflow dispatchMotivation
Benchmarks are resource-intensive (use 8-core runners) and don't need to run on every PR. This change ensures benchmarks only run when explicitly needed:
bench/(e.g.,bench/optimize-rules)Test Plan
bench/prefixed branches🤖 Generated with Claude Code