Skip to content

ci: restrict benchmark workflow to bench/ branches only #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2025
+5 −5
Merged

ci: restrict benchmark workflow to bench/ branches only #77

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd73be5
ci: restrict benchmark workflow to bench/ branches only
ammario Oct 3, 2025
b290523
Merge branch 'main' into ci-bench
ammario Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ name: Benchmarks

on:
workflow_dispatch:
push:
branches:
- 'bench/**'
pull_request:
branches: [main]
paths:
- 'src/rules/**'
- 'benches/**'
- '.github/workflows/benchmark.yml'
branches:
- 'bench/**'
Comment on lines 3 to +10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Misconfigured pull_request filter prevents benchmarks from running

The new trigger filters pull_request.branches to bench/**, but on GitHub Actions this key matches the base branch, not the source branch. Typical benchmark PRs will target main from branches like bench/foo, so this workflow will never trigger for those PRs. The change therefore disables benchmark runs for the very branches it is meant to cover. Consider keeping branches: [main] and adding an if: startsWith(github.head_ref, 'bench/') or a similar condition to gate on the PR’s head branch instead.

Useful? React with 👍 / 👎.


env:
CARGO_TERM_COLOR: always
Expand Down