🤖 refactor: remove atomicWrite proxy and make all writes async

Removed the atomicWrite.ts proxy file and import write-file-atomic directly.
Converted all Config file writes to async, eliminating sync operations.

Changes:
- Deleted src/utils/atomicWrite.ts (unnecessary proxy)
- Config.saveConfig() now async
- Config.saveSecretsConfig() now async
- Config.editConfig() now async
- Config.updateProjectSecrets() now async
- Updated all callers to await these methods
- ExtensionMetadataService imports write-file-atomic directly
- Updated tests to handle async config methods

Benefits:
- Simpler: no proxy layer, direct imports
- Consistent: all file writes are now async
- Non-blocking: no sync I/O operations blocking the event loop
- Better performance: async I/O allows Node.js to handle other work

Author: ammar-agent

src/config.test.ts

@@ -36,15 +36,15 @@ describe("Config", () => {
   });
 
   describe("getAllWorkspaceMetadata with migration", () => {
-    it("should migrate legacy workspace without metadata file", () => {
+    it("should migrate legacy workspace without metadata file", async () => {
       const projectPath = "/fake/project";
       const workspacePath = path.join(config.srcDir, "project", "feature-branch");
 
       // Create workspace directory
       fs.mkdirSync(workspacePath, { recursive: true });
 
       // Add workspace to config without metadata file
-      config.editConfig((cfg) => {
+      await config.editConfig((cfg) => {
         cfg.projects.set(projectPath, {
           workspaces: [{ path: workspacePath }],
         });
@@ -71,7 +71,7 @@ describe("Config", () => {
       expect(workspace.name).toBe("feature-branch");
     });
 
-    it("should use existing metadata file if present (legacy format)", () => {
+    it("should use existing metadata file if present (legacy format)", async () => {
       const projectPath = "/fake/project";
       const workspaceName = "my-feature";
       const workspacePath = path.join(config.srcDir, "project", workspaceName);
@@ -95,7 +95,7 @@ describe("Config", () => {
       fs.writeFileSync(metadataPath, JSON.stringify(existingMetadata));
 
       // Add workspace to config (without id/name, simulating legacy format)
-      config.editConfig((cfg) => {
+      await config.editConfig((cfg) => {
         cfg.projects.set(projectPath, {
           workspaces: [{ path: workspacePath }],
         });

src/config.ts

@@ -3,12 +3,12 @@ import * as path from "path";
 import * as os from "os";
 import * as crypto from "crypto";
 import * as jsonc from "jsonc-parser";
+import writeFileAtomic from "write-file-atomic";
 import type { WorkspaceMetadata, FrontendWorkspaceMetadata } from "./types/workspace";
 import type { Secret, SecretsConfig } from "./types/secrets";
 import type { Workspace, ProjectConfig, ProjectsConfig } from "./types/project";
 import type { RuntimeConfig } from "./types/runtime";
 import { DEFAULT_RUNTIME_CONFIG } from "./constants/workspace";
-import { writeFileAtomicallySync } from "./utils/atomicWrite";
 
 // Re-export project types from dedicated types file (for preload usage)
 export type { Workspace, ProjectConfig, ProjectsConfig };
@@ -71,7 +71,7 @@ export class Config {
     };
   }
 
-  saveConfig(config: ProjectsConfig): void {
+  async saveConfig(config: ProjectsConfig): Promise<void> {
     try {
       if (!fs.existsSync(this.rootDir)) {
         fs.mkdirSync(this.rootDir, { recursive: true });
@@ -81,7 +81,7 @@ export class Config {
         projects: Array.from(config.projects.entries()),
       };
 
-      writeFileAtomicallySync(this.configFile, JSON.stringify(data, null, 2));
+      await writeFileAtomic(this.configFile, JSON.stringify(data, null, 2), "utf-8");
     } catch (error) {
       console.error("Error saving config:", error);
     }
@@ -91,10 +91,10 @@ export class Config {
    * Edit config atomically using a transformation function
    * @param fn Function that takes current config and returns modified config
    */
-  editConfig(fn: (config: ProjectsConfig) => ProjectsConfig): void {
+  async editConfig(fn: (config: ProjectsConfig) => ProjectsConfig): Promise<void> {
     const config = this.loadConfigOrDefault();
     const newConfig = fn(config);
-    this.saveConfig(newConfig);
+    await this.saveConfig(newConfig);
   }
 
   private getProjectName(projectPath: string): string {
@@ -354,9 +354,9 @@ export class Config {
       }
     }
 
-    // Save config if we migrated any workspaces
+    // Save config if we migrated any workspaces (fire and forget - don't block)
     if (configModified) {
-      this.saveConfig(config);
+      void this.saveConfig(config);
     }
 
     return workspaceMetadata;
@@ -479,13 +479,13 @@ ${jsonString}`;
    * Save secrets configuration to JSON file
    * @param config The secrets configuration to save
    */
-  saveSecretsConfig(config: SecretsConfig): void {
+  async saveSecretsConfig(config: SecretsConfig): Promise<void> {
     try {
       if (!fs.existsSync(this.rootDir)) {
         fs.mkdirSync(this.rootDir, { recursive: true });
       }
 
-      writeFileAtomicallySync(this.secretsFile, JSON.stringify(config, null, 2));
+      await writeFileAtomic(this.secretsFile, JSON.stringify(config, null, 2), "utf-8");
     } catch (error) {
       console.error("Error saving secrets config:", error);
       throw error;
@@ -507,10 +507,10 @@ ${jsonString}`;
    * @param projectPath The path to the project
    * @param secrets The secrets to save for the project
    */
-  updateProjectSecrets(projectPath: string, secrets: Secret[]): void {
+  async updateProjectSecrets(projectPath: string, secrets: Secret[]): Promise<void> {
     const config = this.loadSecretsConfig();
     config[projectPath] = secrets;
-    this.saveSecretsConfig(config);
+    await this.saveSecretsConfig(config);
   }
 }
 

src/services/ExtensionMetadataService.ts

@@ -1,12 +1,12 @@
 import { dirname } from "path";
 import { mkdir, readFile } from "fs/promises";
 import { existsSync } from "fs";
+import writeFileAtomic from "write-file-atomic";
 import {
   type ExtensionMetadata,
   type ExtensionMetadataFile,
   getExtensionMetadataPath,
 } from "@/utils/extensionMetadata";
-import { writeFileAtomically } from "@/utils/atomicWrite";
 
 /**
  * Stateless service for managing workspace metadata used by VS Code extension integration.
@@ -78,7 +78,7 @@ export class ExtensionMetadataService {
   private async save(data: ExtensionMetadataFile): Promise<void> {
     try {
       const content = JSON.stringify(data, null, 2);
-      await writeFileAtomically(this.filePath, content);
+      await writeFileAtomic(this.filePath, content, "utf-8");
     } catch (error) {
       console.error("[ExtensionMetadataService] Failed to save metadata:", error);
     }

src/services/ipcMain.ts

@@ -355,7 +355,7 @@ export class IpcMain {
         // Note: metadata.json no longer written - config is the only source of truth
 
         // Update config to include the new workspace (with full metadata)
-        this.config.editConfig((config) => {
+        await this.config.editConfig((config) => {
           let projectConfig = config.projects.get(projectPath);
           if (!projectConfig) {
             // Create project config if it doesn't exist
@@ -483,7 +483,7 @@ export class IpcMain {
           const { oldPath, newPath } = renameResult;
 
           // Update config with new name and path
-          this.config.editConfig((config) => {
+          await this.config.editConfig((config) => {
             const projectConfig = config.projects.get(projectPath);
             if (projectConfig) {
               const workspaceEntry = projectConfig.workspaces.find((w) => w.path === oldPath);
@@ -1111,7 +1111,7 @@ export class IpcMain {
         }
       }
       if (configUpdated) {
-        this.config.saveConfig(projectsConfig);
+        await this.config.saveConfig(projectsConfig);
       }
 
       // Emit metadata event for workspace removal (with null metadata to indicate deletion)
@@ -1210,7 +1210,7 @@ export class IpcMain {
 
         // Add to config with normalized path
         config.projects.set(normalizedPath, projectConfig);
-        this.config.saveConfig(config);
+        await this.config.saveConfig(config);
 
         // Return both the config and the normalized path so frontend can use it
         return Ok({ projectConfig, normalizedPath });
@@ -1220,7 +1220,7 @@ export class IpcMain {
       }
     });
 
-    ipcMain.handle(IPC_CHANNELS.PROJECT_REMOVE, (_event, projectPath: string) => {
+    ipcMain.handle(IPC_CHANNELS.PROJECT_REMOVE, async (_event, projectPath: string) => {
       try {
         const config = this.config.loadConfigOrDefault();
         const projectConfig = config.projects.get(projectPath);
@@ -1238,11 +1238,11 @@ export class IpcMain {
 
         // Remove project from config
         config.projects.delete(projectPath);
-        this.config.saveConfig(config);
+        await this.config.saveConfig(config);
 
         // Also remove project secrets if any
         try {
-          this.config.updateProjectSecrets(projectPath, []);
+          await this.config.updateProjectSecrets(projectPath, []);
         } catch (error) {
           log.error(`Failed to clean up secrets for project ${projectPath}:`, error);
           // Continue - don't fail the whole operation if secrets cleanup fails
@@ -1299,9 +1299,9 @@ export class IpcMain {
 
     ipcMain.handle(
       IPC_CHANNELS.PROJECT_SECRETS_UPDATE,
-      (_event, projectPath: string, secrets: Array<{ key: string; value: string }>) => {
+      async (_event, projectPath: string, secrets: Array<{ key: string; value: string }>) => {
         try {
-          this.config.updateProjectSecrets(projectPath, secrets);
+          await this.config.updateProjectSecrets(projectPath, secrets);
           return Ok(undefined);
         } catch (error) {
           const message = error instanceof Error ? error.message : String(error);