🤖 Fix lint errors from workspace rename changes

Author: ammar-agent

src/App.tsx

@@ -166,12 +166,17 @@ function AppInner() {
     [setProjects]
   );
 
-  const { workspaceMetadata, loading: metadataLoading, createWorkspace, removeWorkspace, renameWorkspace } =
-    useWorkspaceManagement({
-      selectedWorkspace,
-      onProjectsUpdate: handleProjectsUpdate,
-      onSelectedWorkspaceUpdate: setSelectedWorkspace,
-    });
+  const {
+    workspaceMetadata,
+    loading: metadataLoading,
+    createWorkspace,
+    removeWorkspace,
+    renameWorkspace,
+  } = useWorkspaceManagement({
+    selectedWorkspace,
+    onProjectsUpdate: handleProjectsUpdate,
+    onSelectedWorkspaceUpdate: setSelectedWorkspace,
+  });
 
   // NEW: Sync workspace metadata with the stores
   const workspaceStore = useWorkspaceStoreRaw();
@@ -226,11 +231,11 @@ function AppInner() {
   // Restore workspace from URL on mount (if valid)
   // This effect runs once on mount to restore from hash, which takes priority over localStorage
   const [hasRestoredFromHash, setHasRestoredFromHash] = useState(false);
-  
+
   useEffect(() => {
     // Only run once
     if (hasRestoredFromHash) return;
-    
+
     // Wait for metadata to finish loading
     if (metadataLoading) return;
 
@@ -251,18 +256,18 @@ function AppInner() {
         });
       }
     }
-    
+
     setHasRestoredFromHash(true);
   }, [metadataLoading, workspaceMetadata, hasRestoredFromHash, setSelectedWorkspace]);
 
   // Validate selected workspace exists and has all required fields
   useEffect(() => {
     // Don't validate until metadata is loaded
     if (metadataLoading) return;
-    
+
     if (selectedWorkspace) {
       const metadata = workspaceMetadata.get(selectedWorkspace.workspaceId);
-      
+
       if (!metadata) {
         // Workspace was deleted
         console.warn(
@@ -274,9 +279,7 @@ function AppInner() {
         }
       } else if (!selectedWorkspace.namedWorkspacePath && metadata.namedWorkspacePath) {
         // Old localStorage entry missing namedWorkspacePath - update it once
-        console.log(
-          `Updating workspace ${selectedWorkspace.workspaceId} with missing fields`
-        );
+        console.log(`Updating workspace ${selectedWorkspace.workspaceId} with missing fields`);
         setSelectedWorkspace({
           workspaceId: metadata.id,
           projectPath: metadata.projectPath,
@@ -287,13 +290,16 @@ function AppInner() {
     }
   }, [metadataLoading, selectedWorkspace, workspaceMetadata, setSelectedWorkspace]);
 
-  const openWorkspaceInTerminal = useCallback((workspaceId: string) => {
-    // Look up workspace metadata to get the named path (user-friendly symlink)
-    const metadata = workspaceMetadata.get(workspaceId);
-    if (metadata) {
-      void window.api.workspace.openTerminal(metadata.namedWorkspacePath);
-    }
-  }, [workspaceMetadata]);
+  const openWorkspaceInTerminal = useCallback(
+    (workspaceId: string) => {
+      // Look up workspace metadata to get the named path (user-friendly symlink)
+      const metadata = workspaceMetadata.get(workspaceId);
+      if (metadata) {
+        void window.api.workspace.openTerminal(metadata.namedWorkspacePath);
+      }
+    },
+    [workspaceMetadata]
+  );
 
   const handleRemoveProject = useCallback(
     async (path: string) => {
@@ -682,7 +688,10 @@ function AppInner() {
                   key={selectedWorkspace.workspaceId}
                   workspaceId={selectedWorkspace.workspaceId}
                   projectName={selectedWorkspace.projectName}
-                  branch={selectedWorkspace.namedWorkspacePath?.split("/").pop() ?? selectedWorkspace.workspaceId}
+                  branch={
+                    selectedWorkspace.namedWorkspacePath?.split("/").pop() ??
+                    selectedWorkspace.workspaceId
+                  }
                   namedWorkspacePath={selectedWorkspace.namedWorkspacePath ?? ""}
                 />
               </ErrorBoundary>

src/config.test.ts

@@ -35,8 +35,6 @@ describe("Config", () => {
     });
   });
 
-
-
   describe("getAllWorkspaceMetadata with migration", () => {
     it("should migrate legacy workspace without metadata file", () => {
       const projectPath = "/fake/project";

src/config.ts

@@ -157,7 +157,7 @@ export class Config {
   private addPathsToMetadata(
     metadata: WorkspaceMetadata,
     workspacePath: string,
-    projectPath: string
+    _projectPath: string
   ): FrontendWorkspaceMetadata {
     // Both paths are the same now (directory uses workspace name)
     return {
@@ -329,7 +329,9 @@ export class Config {
               workspace.createdAt = metadata.createdAt;
               configModified = true;
 
-              workspaceMetadata.push(this.addPathsToMetadata(metadata, workspace.path, projectPath));
+              workspaceMetadata.push(
+                this.addPathsToMetadata(metadata, workspace.path, projectPath)
+              );
               metadataFound = true;
             }
           }

src/hooks/useWorkspaceManagement.ts

@@ -46,13 +46,15 @@ export function useWorkspaceManagement({
 
   // Subscribe to metadata updates (for create/rename/delete operations)
   useEffect(() => {
-    const unsubscribe = window.api.workspace.onMetadata((event: { workspaceId: string; metadata: FrontendWorkspaceMetadata }) => {
-      setWorkspaceMetadata((prev) => {
-        const updated = new Map(prev);
-        updated.set(event.workspaceId, event.metadata);
-        return updated;
-      });
-    });
+    const unsubscribe = window.api.workspace.onMetadata(
+      (event: { workspaceId: string; metadata: FrontendWorkspaceMetadata }) => {
+        setWorkspaceMetadata((prev) => {
+          const updated = new Map(prev);
+          updated.set(event.workspaceId, event.metadata);
+          return updated;
+        });
+      }
+    );
 
     return () => {
       unsubscribe();

src/services/agentSession.ts

@@ -151,7 +151,7 @@ export class AgentSession {
     assert(trimmedWorkspacePath.length > 0, "workspacePath must not be empty");
 
     const normalizedWorkspacePath = path.resolve(trimmedWorkspacePath);
-    const existing = await this.aiService.getWorkspaceMetadata(this.workspaceId);
+    const existing = this.aiService.getWorkspaceMetadata(this.workspaceId);
 
     if (existing.success) {
       // Metadata already exists, verify workspace path matches

src/services/aiService.ts

@@ -7,7 +7,7 @@ import { applyToolOutputRedaction } from "@/utils/messages/applyToolOutputRedact
 import type { Result } from "@/types/result";
 import { Ok, Err } from "@/types/result";
 import type { WorkspaceMetadata } from "@/types/workspace";
-import { WorkspaceMetadataSchema } from "@/types/workspace";
+
 import type { CmuxMessage, CmuxTextPart } from "@/types/message";
 import { createCmuxMessage } from "@/types/message";
 import type { Config } from "@/config";
@@ -180,7 +180,7 @@ export class AIService extends EventEmitter {
     return this.mockModeEnabled;
   }
 
-  async getWorkspaceMetadata(workspaceId: string): Promise<Result<WorkspaceMetadata>> {
+  getWorkspaceMetadata(workspaceId: string): Result<WorkspaceMetadata> {
     try {
       // Get all workspace metadata (which includes migration logic)
       // This ensures we always get complete metadata with all required fields
@@ -510,7 +510,7 @@ export class AIService extends EventEmitter {
       }
 
       // Get workspace metadata to retrieve workspace path
-      const metadataResult = await this.getWorkspaceMetadata(workspaceId);
+      const metadataResult = this.getWorkspaceMetadata(workspaceId);
       if (!metadataResult.success) {
         return Err({ type: "unknown", raw: metadataResult.error });
       }
@@ -522,7 +522,7 @@ export class AIService extends EventEmitter {
       if (!workspace) {
         return Err({ type: "unknown", raw: `Workspace ${workspaceId} not found in config` });
       }
-      
+
       // Get workspace path (directory name uses workspace name)
       const workspacePath = this.config.getWorkspacePath(metadata.projectPath, metadata.name);
 

src/services/gitService.test.ts

@@ -49,7 +49,9 @@ describe("removeWorktreeSafe", () => {
 
   test("should instantly remove clean worktree via rename", async () => {
     // Create a worktree
-    const result = await createWorktree(mockConfig, repoPath, "test-branch", { trunkBranch: "main" });
+    const result = await createWorktree(mockConfig, repoPath, "test-branch", {
+      trunkBranch: "main",
+    });
     expect(result.success).toBe(true);
     const worktreePath = result.path!;
 
@@ -80,7 +82,9 @@ describe("removeWorktreeSafe", () => {
 
   test("should block removal of dirty worktree", async () => {
     // Create a worktree
-    const result = await createWorktree(mockConfig, repoPath, "dirty-branch", { trunkBranch: "main" });
+    const result = await createWorktree(mockConfig, repoPath, "dirty-branch", {
+      trunkBranch: "main",
+    });
     expect(result.success).toBe(true);
     const worktreePath = result.path!;
 
@@ -107,7 +111,9 @@ describe("removeWorktreeSafe", () => {
 
   test("should handle already-deleted worktree gracefully", async () => {
     // Create a worktree
-    const result = await createWorktree(mockConfig, repoPath, "temp-branch", { trunkBranch: "main" });
+    const result = await createWorktree(mockConfig, repoPath, "temp-branch", {
+      trunkBranch: "main",
+    });
     expect(result.success).toBe(true);
     const worktreePath = result.path!;
 
@@ -122,7 +128,9 @@ describe("removeWorktreeSafe", () => {
 
   test("should remove clean worktree with staged changes using git", async () => {
     // Create a worktree
-    const result = await createWorktree(mockConfig, repoPath, "staged-branch", { trunkBranch: "main" });
+    const result = await createWorktree(mockConfig, repoPath, "staged-branch", {
+      trunkBranch: "main",
+    });
     expect(result.success).toBe(true);
     const worktreePath = result.path!;
 
@@ -142,7 +150,9 @@ describe("removeWorktreeSafe", () => {
 
   test("should call onBackgroundDelete callback on errors", async () => {
     // Create a worktree
-    const result = await createWorktree(mockConfig, repoPath, "callback-branch", { trunkBranch: "main" });
+    const result = await createWorktree(mockConfig, repoPath, "callback-branch", {
+      trunkBranch: "main",
+    });
     expect(result.success).toBe(true);
     const worktreePath = result.path!;
 
@@ -184,15 +194,19 @@ describe("isWorktreeClean", () => {
   });
 
   test("should return true for clean worktree", async () => {
-    const result = await createWorktree(mockConfig, repoPath, "clean-check", { trunkBranch: "main" });
+    const result = await createWorktree(mockConfig, repoPath, "clean-check", {
+      trunkBranch: "main",
+    });
     expect(result.success).toBe(true);
 
     const isClean = await isWorktreeClean(result.path!);
     expect(isClean).toBe(true);
   });
 
   test("should return false for worktree with uncommitted changes", async () => {
-    const result = await createWorktree(mockConfig, repoPath, "dirty-check", { trunkBranch: "main" });
+    const result = await createWorktree(mockConfig, repoPath, "dirty-check", {
+      trunkBranch: "main",
+    });
     expect(result.success).toBe(true);
     const worktreePath = result.path!;
 

src/services/ipcMain.ts

@@ -25,7 +25,6 @@ import { createBashTool } from "@/services/tools/bash";
 import type { BashToolResult } from "@/types/tools";
 import { secretsToRecord } from "@/types/secrets";
 import { DisposableTempDir } from "@/services/tempDir";
-import type { WorkspaceMetadata, FrontendWorkspaceMetadata } from "@/types/workspace";
 
 /**
  * IpcMain - Manages all IPC handlers and service coordination
@@ -122,8 +121,6 @@ export class IpcMain {
     this.sessions.delete(workspaceId);
   }
 
-
-
   /**
    * Register all IPC handlers and setup event forwarding
    * @param ipcMain - Electron's ipcMain module
@@ -267,7 +264,7 @@ export class IpcMain {
 
     ipcMain.handle(
       IPC_CHANNELS.WORKSPACE_RENAME,
-      async (_event, workspaceId: string, newName: string) => {
+      (_event, workspaceId: string, newName: string) => {
         try {
           // Validate workspace name
           const validation = validateWorkspaceName(newName);
@@ -276,7 +273,7 @@ export class IpcMain {
           }
 
           // Get current metadata
-          const metadataResult = await this.aiService.getWorkspaceMetadata(workspaceId);
+          const metadataResult = this.aiService.getWorkspaceMetadata(workspaceId);
           if (!metadataResult.success) {
             return Err(`Failed to get workspace metadata: ${metadataResult.error}`);
           }
@@ -305,8 +302,6 @@ export class IpcMain {
           const { projectPath, workspacePath } = workspace;
 
           // Compute new path (based on name)
-          const projectName =
-            projectPath.split("/").pop() ?? projectPath.split("\\").pop() ?? "unknown";
           const oldPath = workspacePath;
           const newPath = this.config.getWorkspacePath(projectPath, newName);
 
@@ -374,7 +369,7 @@ export class IpcMain {
       }
     });
 
-    ipcMain.handle(IPC_CHANNELS.WORKSPACE_GET_INFO, async (_event, workspaceId: string) => {
+    ipcMain.handle(IPC_CHANNELS.WORKSPACE_GET_INFO, (_event, workspaceId: string) => {
       // Get complete metadata from config (includes paths)
       const allMetadata = this.config.getAllWorkspaceMetadata();
       return allMetadata.find((m) => m.id === workspaceId) ?? null;
@@ -573,7 +568,7 @@ export class IpcMain {
       ) => {
         try {
           // Get workspace metadata
-          const metadataResult = await this.aiService.getWorkspaceMetadata(workspaceId);
+          const metadataResult = this.aiService.getWorkspaceMetadata(workspaceId);
           if (!metadataResult.success) {
             return Err(`Failed to get workspace metadata: ${metadataResult.error}`);
           }
@@ -587,7 +582,7 @@ export class IpcMain {
           if (!workspace) {
             return Err(`Workspace ${workspaceId} not found in config`);
           }
-          
+
           // Get workspace path (directory name uses workspace name)
           const namedPath = this.config.getWorkspacePath(metadata.projectPath, metadata.name);
 
@@ -714,15 +709,13 @@ export class IpcMain {
   ): Promise<{ success: boolean; error?: string }> {
     try {
       // Get workspace metadata
-      const metadataResult = await this.aiService.getWorkspaceMetadata(workspaceId);
+      const metadataResult = this.aiService.getWorkspaceMetadata(workspaceId);
       if (!metadataResult.success) {
         // If metadata doesn't exist, workspace is already gone - consider it success
         log.info(`Workspace ${workspaceId} metadata not found, considering removal successful`);
         return { success: true };
       }
 
-      const metadata = metadataResult.data;
-
       // Get actual workspace path from config (handles both legacy and new format)
       const workspace = this.config.findWorkspace(workspaceId);
       if (!workspace) {
@@ -807,7 +800,7 @@ export class IpcMain {
       // because the worktree might be deleted (so getMainWorktreeFromWorktree fails)
       const projectsConfig = this.config.loadConfigOrDefault();
       let configUpdated = false;
-      for (const [projectPath, projectConfig] of projectsConfig.projects.entries()) {
+      for (const [_projectPath, projectConfig] of projectsConfig.projects.entries()) {
         const initialCount = projectConfig.workspaces.length;
         projectConfig.workspaces = projectConfig.workspaces.filter((w) => w.path !== workspacePath);
         if (projectConfig.workspaces.length < initialCount) {

src/utils/commands/sources.ts

@@ -154,7 +154,7 @@ export function buildCoreSources(p: BuildSourcesParams): Array<() => CommandActi
     }
 
     // Remove current workspace (rename action intentionally omitted until we add a proper modal)
-    if (selected && selected.namedWorkspacePath) {
+    if (selected?.namedWorkspacePath) {
       const workspaceDisplayName = `${selected.projectName}/${selected.namedWorkspacePath.split("/").pop() ?? selected.namedWorkspacePath}`;
       list.push({
         id: "ws:open-terminal-current",