🤖 refactor: rename CMUX_TEST_ROOT to CMUX_ROOT, remove mandatory -dev suffix

Instead of automatically appending '-dev' suffix based on NODE_ENV, let
developers explicitly control the data directory via CMUX_ROOT environment
variable. This restores the old behavior where devs decide when to switch
roots.

Changes:
- Renamed CMUX_TEST_ROOT to CMUX_ROOT in all files
- Removed NODE_ENV=development from 'make start' target
- Removed automatic -dev suffix logic from getCmuxHome()
- Simplified paths.ts back to simple env var override

_Generated with `cmux`_

Author: ammar-agent

Makefile

@@ -115,7 +115,7 @@ dev-server: node_modules/.installed build-main ## Start server mode with hot rel
 
 
 start: node_modules/.installed build-main build-preload build-static ## Build and start Electron app
-	@NODE_ENV=development bun x electron --remote-debugging-port=9222 .
+	@bun x electron --remote-debugging-port=9222 .
 
 ## Build targets (can run in parallel)
 build: node_modules/.installed src/version.ts build-renderer build-main build-preload build-icons build-static ## Build all targets

src/constants/paths.ts

@@ -3,8 +3,7 @@ import { join } from "path";
 
 /**
  * Get the root directory for all cmux configuration and data.
- * Can be overridden with CMUX_TEST_ROOT environment variable.
- * Appends '-dev' suffix when NODE_ENV=development (explicit dev mode).
+ * Can be overridden with CMUX_ROOT environment variable.
  *
  * This is a getter function to support test mocking of os.homedir().
  *
@@ -13,16 +12,7 @@ import { join } from "path";
  */
 export function getCmuxHome(): string {
   // eslint-disable-next-line no-restricted-syntax, no-restricted-globals
-  if (process.env.CMUX_TEST_ROOT) {
-    // eslint-disable-next-line no-restricted-syntax, no-restricted-globals
-    return process.env.CMUX_TEST_ROOT;
-  }
-
-  const baseName = ".cmux";
-  // Use -dev suffix only when explicitly in development mode
-  // eslint-disable-next-line no-restricted-syntax, no-restricted-globals
-  const suffix = process.env.NODE_ENV === "development" ? "-dev" : "";
-  return join(homedir(), baseName + suffix);
+  return process.env.CMUX_ROOT ?? join(homedir(), ".cmux");
 }
 
 /**

src/main-desktop.ts

@@ -75,7 +75,7 @@ const forceDistLoad = process.env.CMUX_E2E_LOAD_DIST === "1";
 
 if (isE2ETest) {
   // For e2e tests, use a test-specific userData directory
-  // Note: getCmuxHome() already respects CMUX_TEST_ROOT for test isolation
+  // Note: getCmuxHome() already respects CMUX_ROOT for test isolation
   const e2eUserData = path.join(getCmuxHome(), "user-data");
   try {
     fs.mkdirSync(e2eUserData, { recursive: true });

tests/e2e/electronTest.ts

@@ -88,7 +88,7 @@ function buildTarget(target: string): void {
 
 export const electronTest = base.extend<ElectronFixtures>({
   workspace: async ({}, use, testInfo) => {
-    const envRoot = process.env.CMUX_TEST_ROOT ?? "";
+    const envRoot = process.env.CMUX_ROOT ?? "";
     const baseRoot = envRoot || defaultTestRoot;
     const uniqueTestId = testInfo.testId || testInfo.title || `test-${Date.now()}`;
     const testRoot = envRoot ? baseRoot : path.join(baseRoot, sanitizeForPath(uniqueTestId));
@@ -195,7 +195,7 @@ export const electronTest = base.extend<ElectronFixtures>({
       }
       electronEnv.ELECTRON_DISABLE_SECURITY_WARNINGS = "true";
       electronEnv.CMUX_MOCK_AI = electronEnv.CMUX_MOCK_AI ?? "1";
-      electronEnv.CMUX_TEST_ROOT = configRoot;
+      electronEnv.CMUX_ROOT = configRoot;
       electronEnv.CMUX_E2E = "1";
       electronEnv.CMUX_E2E_LOAD_DIST = shouldLoadDist ? "1" : "0";
       electronEnv.VITE_DISABLE_MERMAID = "1";