Use path-based metadata lookup for stable and legacy workspaces

Instead of extracting workspace ID from path (which fails for legacy
workspaces), build a pathToMetadata map that maps both stableWorkspacePath
and namedWorkspacePath to their metadata. This handles both new stable-ID
workspaces and legacy name-based workspaces.

Fixes E2E test failures where workspaces weren't appearing.

Author: ammar-agent

src/App.tsx

@@ -1,11 +1,12 @@
-import { useState, useEffect, useCallback, useRef } from "react";
+import { useState, useEffect, useCallback, useRef, useMemo } from "react";
 import styled from "@emotion/styled";
 import { Global, css } from "@emotion/react";
 import { GlobalColors } from "./styles/colors";
 import { GlobalFonts } from "./styles/fonts";
 import { GlobalScrollbars } from "./styles/scrollbars";
 import type { ProjectConfig } from "./config";
 import type { WorkspaceSelection } from "./components/ProjectSidebar";
+import type { WorkspaceMetadataWithPaths } from "./types/workspace";
 import { LeftSidebar } from "./components/LeftSidebar";
 import NewWorkspaceModal from "./components/NewWorkspaceModal";
 import { AIView } from "./components/AIView";
@@ -172,6 +173,17 @@ function AppInner() {
       onSelectedWorkspaceUpdate: setSelectedWorkspace,
     });
 
+  // Build path-to-metadata lookup map (handles both stable and legacy paths)
+  const pathToMetadata = useMemo(() => {
+    const map = new Map<string, WorkspaceMetadataWithPaths>();
+    for (const metadata of workspaceMetadata.values()) {
+      // Map both stable path (with ID) and named path (with name/legacy)
+      map.set(metadata.stableWorkspacePath, metadata);
+      map.set(metadata.namedWorkspacePath, metadata);
+    }
+    return map;
+  }, [workspaceMetadata]);
+
   // NEW: Sync workspace metadata with the stores
   const workspaceStore = useWorkspaceStoreRaw();
   const gitStatusStore = useGitStatusStoreRaw();
@@ -321,11 +333,9 @@ function AppInner() {
         result.set(
           projectPath,
           config.workspaces.slice().sort((a, b) => {
-            // Extract workspace ID from path
-            const aId = a.path.replace(/\\/g, "/").split("/").pop() ?? "";
-            const bId = b.path.replace(/\\/g, "/").split("/").pop() ?? "";
-            const aMeta = workspaceMetadata.get(aId);
-            const bMeta = workspaceMetadata.get(bId);
+            // Look up metadata by workspace path (handles both stable and legacy paths)
+            const aMeta = pathToMetadata.get(a.path);
+            const bMeta = pathToMetadata.get(b.path);
             if (!aMeta || !bMeta) return 0;
 
             // Get timestamp of most recent user message (0 if never used)
@@ -349,7 +359,7 @@ function AppInner() {
       }
       return true;
     },
-    [projects, workspaceMetadata, workspaceRecency]
+    [projects, workspaceMetadata, workspaceRecency, pathToMetadata]
   );
 
   const handleNavigateWorkspace = useCallback(
@@ -377,9 +387,8 @@ function AppInner() {
       const targetWorkspace = sortedWorkspaces[targetIndex];
       if (!targetWorkspace) return;
 
-      // Extract workspace ID from path
-      const workspaceId = targetWorkspace.path.replace(/\\/g, "/").split("/").pop() ?? "";
-      const metadata = workspaceMetadata.get(workspaceId);
+      // Look up metadata by workspace path (handles both stable and legacy paths)
+      const metadata = pathToMetadata.get(targetWorkspace.path);
       if (!metadata) return;
 
       setSelectedWorkspace({
@@ -389,7 +398,7 @@ function AppInner() {
         workspaceId: metadata.id,
       });
     },
-    [selectedWorkspace, sortedWorkspacesByProject, workspaceMetadata, setSelectedWorkspace]
+    [selectedWorkspace, sortedWorkspacesByProject, pathToMetadata, setSelectedWorkspace]
   );
 
   // Register command sources with registry

src/components/ProjectSidebar.tsx

@@ -512,6 +512,17 @@ const ProjectSidebarInner: React.FC<ProjectSidebarProps> = ({
   onUpdateSecrets,
   sortedWorkspacesByProject,
 }) => {
+  // Build path-to-metadata lookup map (handles both stable and legacy paths)
+  const pathToMetadata = React.useMemo(() => {
+    const map = new Map<string, WorkspaceMetadataWithPaths>();
+    for (const metadata of workspaceMetadata.values()) {
+      // Map both stable path (with ID) and named path (with name/legacy)
+      map.set(metadata.stableWorkspacePath, metadata);
+      map.set(metadata.namedWorkspacePath, metadata);
+    }
+    return map;
+  }, [workspaceMetadata]);
+
   // Workspace-specific subscriptions moved to WorkspaceListItem component
 
   // Store as array in localStorage, convert to Set for usage
@@ -822,12 +833,11 @@ const ProjectSidebarInner: React.FC<ProjectSidebarProps> = ({
                             </WorkspaceHeader>
                             {(sortedWorkspacesByProject.get(projectPath) ?? config.workspaces).map(
                               (workspace) => {
-                                // Extract workspace ID from path (path format: ~/.cmux/src/projectName/workspaceId)
-                                // Handle both Unix (/) and Windows (\) path separators
-                                const pathParts = workspace.path.replace(/\\/g, "/").split("/");
-                                const workspaceId = pathParts[pathParts.length - 1] ?? "";
-                                const metadata = workspaceMetadata.get(workspaceId);
+                                // Look up metadata by workspace path (handles both stable ID paths and legacy name paths)
+                                const metadata = pathToMetadata.get(workspace.path);
                                 if (!metadata) return null;
+
+                                const workspaceId = metadata.id;
                                 const isSelected =
                                   selectedWorkspace?.workspacePath === workspace.path;