🤖 Fix E2E tests: use legacy ID format for metadata.json lookup

The migration logic in getAllWorkspaceMetadata() was trying to load
metadata.json using workspace basename first (e.g., 'demo-review'),
then falling back to legacy ID format (e.g., 'demo-repo-demo-review').

However:
- New workspaces have metadata in config (id + name fields), not metadata.json
- E2E tests and legacy workspaces use the legacy ID format (project-workspace)

The first check (workspace basename) would never succeed for valid cases:
- It's unnecessary for new workspaces (they skip metadata.json lookup)
- It fails for E2E tests/legacy workspaces (they use legacy ID format)

This caused all E2E tests to timeout waiting for workspace list items to appear,
because workspaces weren't being discovered during config migration.

Fix: Remove the redundant first check and go straight to legacy ID format.
This makes E2E tests work while maintaining backward compatibility with
existing workspaces.

🤖 Fix formatting in config.ts

Author: ammar-agent

src/config.ts

@@ -276,8 +276,9 @@ export class Config {
           }
 
           // LEGACY FORMAT: Fall back to reading metadata.json
-          // Try workspace basename first (for new stable ID workspaces)
-          let metadataPath = path.join(this.getSessionDir(workspaceBasename), "metadata.json");
+          // Try legacy ID format first (project-workspace) - used by E2E tests and old workspaces
+          const legacyId = this.generateWorkspaceId(projectPath, workspace.path);
+          const metadataPath = path.join(this.getSessionDir(legacyId), "metadata.json");
           let metadataFound = false;
 
           if (fs.existsSync(metadataPath)) {
@@ -304,38 +305,6 @@ export class Config {
             metadataFound = true;
           }
 
-          // Try legacy ID format (project-workspace)
-          if (!metadataFound) {
-            const legacyId = this.generateWorkspaceId(projectPath, workspace.path);
-            metadataPath = path.join(this.getSessionDir(legacyId), "metadata.json");
-
-            if (fs.existsSync(metadataPath)) {
-              const data = fs.readFileSync(metadataPath, "utf-8");
-              let metadata = JSON.parse(data) as WorkspaceMetadata;
-
-              // Ensure required fields are present
-              if (!metadata.name || !metadata.projectPath) {
-                metadata = {
-                  ...metadata,
-                  name: metadata.name ?? workspaceBasename,
-                  projectPath: metadata.projectPath ?? projectPath,
-                  projectName: metadata.projectName ?? projectName,
-                };
-              }
-
-              // Migrate to config for next load
-              workspace.id = metadata.id;
-              workspace.name = metadata.name;
-              workspace.createdAt = metadata.createdAt;
-              configModified = true;
-
-              workspaceMetadata.push(
-                this.addPathsToMetadata(metadata, workspace.path, projectPath)
-              );
-              metadataFound = true;
-            }
-          }
-
           // No metadata found anywhere - create basic metadata
           if (!metadataFound) {
             const legacyId = this.generateWorkspaceId(projectPath, workspace.path);