fix: avoid referencing loki when disabled (#61)

Author: ethanndickson

README.md

@@ -22,7 +22,7 @@ Logs will be scraped from all pods in the Kubernetes cluster.
 
 ```bash
 helm repo add coder-observability https://helm.coder.com/observability
-helm upgrade --install coder-observability coder-observability/coder-observability --version 0.4.1 --namespace coder-observability --create-namespace
+helm upgrade --install coder-observability coder-observability/coder-observability --version 0.4.2 --namespace coder-observability --create-namespace
 ```
 
 ## Requirements

coder-observability/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 name: coder-observability
 description: Gain insights into your Coder deployment
 type: application
-version: 0.4.1
+version: 0.4.2
 dependencies:
   - name: pyroscope
     condition: pyroscope.enabled

coder-observability/templates/_collector-config.tpl

@@ -4,6 +4,8 @@
 {{ $agent.logging }}
 {{ $agent.discovery }}
 
+{{- if .Values.loki.enabled }}
+
 discovery.relabel "pod_logs" {
   targets = discovery.kubernetes.pods.targets
   {{ $agent.commonRelabellings | nindent 2 }}
@@ -25,6 +27,7 @@ discovery.relabel "pod_logs" {
   {{ $agent.podLogsRelabelRules | trim | nindent 2 }}
   {{- end }}
 }
+{{- end }}
 
 discovery.relabel "pod_metrics" {
   targets = discovery.kubernetes.pods.targets
@@ -122,6 +125,7 @@ discovery.relabel "pod_pprof" {
   {{ $agent.podMetricsRelabelRules | trim | nindent 2 }}
   {{- end }}
 }
+{{- if .Values.loki.enabled }}
 
 local.file_match "pod_logs" {
   path_targets = discovery.relabel.pod_logs.output
@@ -194,6 +198,7 @@ loki.process "pod_logs" {
 
   forward_to = [loki.write.loki.receiver]
 }
+{{- end }}
 {{ if $agent.extraBlocks -}}
 {{ $agent.extraBlocks }}
 {{- end }}
@@ -379,15 +384,19 @@ otelcol.exporter.prometheus "to_prometheus" {
     prometheus.remote_write.default.receiver,
   ]
 }
+{{- if .Values.loki.enabled }}
 otelcol.exporter.loki "to_loki" {
   forward_to = [
     loki.write.loki.receiver,
   ]
 }
+{{- end }}
 otelcol.processor.batch "default" {
   output {
     metrics = [otelcol.exporter.prometheus.to_prometheus.input]
+{{- if .Values.loki.enabled }}
     logs    = [otelcol.exporter.loki.to_loki.input]
+{{- end }}
   }
 }
 {{- end -}}