Skip to content

Conversation

schahal
Copy link
Contributor

@schahal schahal commented Oct 6, 2025

Closes #458

Description

It only sources the bashrc file if it exists (as the startup/install scripts will fail if the workspace doesn't have that)

Type of Change

  • New module
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/coder/modules/claude-code
New version: v3.0.2 <--- Maintainers, I'll have to lookup how to bump this for this project
Breaking change: [ ] Yes [x] No

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally

Related Issues

@matifali matifali added the version:patch Add to PRs requiring a patch version upgrade label Oct 6, 2025
@schahal
Copy link
Contributor Author

schahal commented Oct 6, 2025

@DevelopmentCats , I'm trying to follow CONTRIBUTING.md, but running

./.github/scripts/version-bump.sh patch

on this branch doesn't return anything:

$ ./.github/scripts/version-bump.sh patch
🔍 Detecting modified modules...
$

Are there other steps needed, you think?

@DevelopmentCats
Copy link
Contributor

@DevelopmentCats , I'm trying to follow CONTRIBUTING.md, but running

./.github/scripts/version-bump.sh patch

on this branch doesn't return anything:

$ ./.github/scripts/version-bump.sh patch
🔍 Detecting modified modules...
$

Are there other steps needed, you think?

You can just manually replace the versions in README if you want.

This script essentially just updates all the version references in the README to match what they should based on the last tag and requested bump type.

Does the script not exist for you at all in your version?

@schahal
Copy link
Contributor Author

schahal commented Oct 7, 2025

Thanks, I bumped the version!

(i think the "issue" with the script was this line in the script: changed_files=$(git diff --name-only "${base_ref}"...HEAD), which may not detect in my situation as my pr branch is main of my fork (which base_ref defaults to, so equals HEAD... i think)

@matifali matifali added version:patch Add to PRs requiring a patch version upgrade and removed version:patch Add to PRs requiring a patch version upgrade labels Oct 7, 2025
@matifali matifali changed the title chore(claude-code): source bashrc file only if it exists fix(claude-code): source bashrc file only if it exists Oct 7, 2025
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@matifali matifali enabled auto-merge (squash) October 7, 2025 06:28
@schahal
Copy link
Contributor Author

schahal commented Oct 7, 2025

👍 thank you for the quick iterations!

Looks like the PR didn't auto-merge because the branch was out-of-date, so I just updated.

@matifali matifali merged commit b4e9545 into coder:main Oct 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:patch Add to PRs requiring a patch version upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

agentapi server not starting up after upgrade of claude-code module to v3
3 participants