Skip to content

Fix time range selection issue #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

Spikatrix
Copy link

@Spikatrix Spikatrix commented Jun 16, 2023

Fixes https://github.com/fluxninja/cloud/issues/8859

Summary by OpenAI

Bug fix:
- Updated TimePickerWithHistory component to track mounted state and update fnGlobalTimeRange only when it changes
- Modified TimeRangePicker value prop to use fnGlobalTimeRange if available

🎉 A bug we've slain, our code's now right,
With TimePicker updates taking flight.
Mounted state we track with care,
And fnGlobalTimeRange we now share. 🕰️

@Spikatrix Spikatrix requested a review from gurinder39 June 16, 2023 13:39
@github-actions
Copy link

🤖 OpenAI

Here is the final summary of changes:

This pull request updates the `Picker` component to improve its handling of global time range updates. It adds a reference to track if the component has mounted and updates `fnGlobalTimeRange` only when it changes. Additionally, it modifies the `value` prop of `TimeRangePicker` to use `fnGlobalTimeRange` if available.
Files Summary
public/app/core/components/TimePicker/TimePickerWithHistory.tsx The diff improves the handling of global time range updates by tracking the component's mount status and updating fnGlobalTimeRange only when necessary. It also modifies the value prop of TimeRangePicker.

Chat with 🤖 OpenAI Bot (@openai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @openai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Ignoring further reviews

  • Type @openai: ignore anywhere in the PR description to ignore further reviews from the bot.


In the recent run, only the files that changed from the base of the PR and between 54feedf76d283171d23d92f4e17d3b937624ffcb and 1ab68dbd8f6dd8454273d7a520eb58732d553cde commits were reviewed.

@Spikatrix Spikatrix merged commit 9d90474 into fluxninja_micro_frontends Jun 16, 2023
@Spikatrix Spikatrix deleted the jaseel/timerange-fix branch June 16, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant