refactor(cms-mutations): extract delete mutation

Author: mydearxym

lib/groupher_server_web/schema/Helper/mutations.ex

@@ -84,4 +84,20 @@ defmodule GroupherServerWeb.Schema.Helper.Mutations do
       end
     end
   end
+
+  # TODO: if post belongs to multi communities, unset instead delete
+  defmacro article_delete_mutation(thread) do
+    quote do
+      @desc unquote("delete a #{thread}, not delete")
+      field unquote(:"delete_#{thread}"), unquote(thread) do
+        arg(:id, non_null(:id))
+
+        middleware(M.Authorize, :login)
+        middleware(M.PassportLoader, source: unquote(thread))
+        middleware(M.Passport, claim: unquote("owner;cms->c?->#{to_string(thread)}.delete"))
+
+        resolve(&R.CMS.delete_content/3)
+      end
+    end
+  end
 end

lib/groupher_server_web/schema/cms/mutations/job.ex

@@ -74,17 +74,7 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Job do
     article_upvote_mutation(:job)
     article_pin_mutation(:job)
     article_trash_mutation(:job)
+    article_delete_mutation(:job)
     #############
-
-    @desc "delete a job"
-    field :delete_job, :job do
-      arg(:id, non_null(:id))
-
-      middleware(M.Authorize, :login)
-      middleware(M.PassportLoader, source: :job)
-      middleware(M.Passport, claim: "owner;cms->c?->job.delete")
-
-      resolve(&R.CMS.delete_content/3)
-    end
   end
 end

lib/groupher_server_web/schema/cms/mutations/post.ex

@@ -48,18 +48,7 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Post do
     article_upvote_mutation(:post)
     article_pin_mutation(:post)
     article_trash_mutation(:post)
+    article_delete_mutation(:post)
     #############
-
-    @desc "delete a cms/post"
-    # TODO: if post belongs to multi communities, unset instead delete
-    field :delete_post, :post do
-      arg(:id, non_null(:id))
-
-      middleware(M.Authorize, :login)
-      middleware(M.PassportLoader, source: :post)
-      middleware(M.Passport, claim: "owner;cms->c?->post.delete")
-
-      resolve(&R.CMS.delete_content/3)
-    end
   end
 end

test/groupher_server_web/mutation/cms/job_test.exs

@@ -282,6 +282,7 @@ defmodule GroupherServer.Test.Mutation.Job do
       }
     }
     """
+    @tag :wip2
     test "can delete a job by job's owner", ~m(owner_conn job)a do
       deleted = owner_conn |> mutation_result(@query, %{id: job.id}, "deleteJob")
 

test/groupher_server_web/mutation/cms/post_test.exs

@@ -142,6 +142,7 @@ defmodule GroupherServer.Test.Mutation.Post do
       }
     }
     """
+    @tag :wip2
     test "delete a post by post's owner", ~m(owner_conn post)a do
       deleted = owner_conn |> mutation_result(@query, %{id: post.id}, "deletePost")