refactor: move logic adjust

Author: mydearxym

lib/groupher_server/cms/delegates/article_community.ex

@@ -145,7 +145,10 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommunity do
   def move_article(thread, article_id, community_id) do
     with {:ok, info} <- match(thread),
          {:ok, community} <- ORM.find(Community, community_id),
-         {:ok, article} <- ORM.find(info.model, article_id, preload: [:communities]) do
+         {:ok, article} <-
+           ORM.find(info.model, article_id, preload: [:communities, :original_community]) do
+      cur_original_community = article.original_community
+
       Multi.new()
       |> Multi.run(:change_original_community, fn _, _ ->
         article
@@ -156,15 +159,21 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommunity do
       |> Multi.run(:unmirror_article, fn _, %{change_original_community: article} ->
         article
         |> Ecto.Changeset.change()
-        |> Ecto.Changeset.put_assoc(:communities, article.communities -- [community])
+        |> Ecto.Changeset.put_assoc(:communities, article.communities -- [cur_original_community])
+        |> Repo.update()
+      end)
+      |> Multi.run(:mirror_target_community, fn _, %{unmirror_article: article} ->
+        article
+        |> Ecto.Changeset.change()
+        |> Ecto.Changeset.put_assoc(:communities, article.communities ++ [community])
         |> Repo.update()
       end)
       |> Repo.transaction()
       |> result()
     end
   end
 
-  defp result({:ok, %{change_original_community: result}}), do: result |> done()
+  defp result({:ok, %{mirror_target_community: result}}), do: result |> done()
   defp result({:error, _, result, _steps}), do: {:error, result}
 
   @doc """

lib/groupher_server_web/resolvers/cms_resolver.ex

@@ -298,6 +298,10 @@ defmodule GroupherServerWeb.Resolvers.CMS do
     CMS.unmirror_article(thread, id, community_id)
   end
 
+  def move_article(_root, ~m(thread id community_id)a, _info) do
+    CMS.move_article(thread, id, community_id)
+  end
+
   # #######################
   # comemnts ..
   # #######################

lib/groupher_server_web/schema/cms/mutations/operation.ex

@@ -130,15 +130,15 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Operation do
       resolve(&R.CMS.unmirror_article/3)
     end
 
-    # @desc "move article to other community"
-    # field :move_article, :article do
-    #   arg(:id, non_null(:id))
-    #   arg(:community_id, non_null(:id))
-    #   arg(:thread, :thread, default_value: :post)
-
-    #   middleware(M.Authorize, :login)
-    #   middleware(M.Passport, claim: "cms->t?.community.mirror")
-    #   resolve(&R.CMS.mirror_article/3)
-    # end
+    @desc "move article to other community"
+    field :move_article, :article do
+      arg(:id, non_null(:id))
+      arg(:community_id, non_null(:id))
+      arg(:thread, :thread, default_value: :post)
+
+      middleware(M.Authorize, :login)
+      middleware(M.Passport, claim: "cms->t?.community.move")
+      resolve(&R.CMS.move_article/3)
+    end
   end
 end

lib/helper/certification.ex

@@ -52,8 +52,10 @@ defmodule Helper.Certification do
         "category.unset",
         "thread.create",
         "post.community.mirror",
+        "post.community.move",
         "post.community.unmirror",
         "job.community.mirror",
+        "job.community.move",
         "job.community.unmirror",
         # flag on content
         "post.pin",

test/groupher_server/cms/article_community/job_test.exs

@@ -34,7 +34,7 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Job do
       {:ok, job} = ORM.find(CMS.Job, job.id, preload: [:original_community, :communities])
 
       assert job.original_community.id == community2.id
-      assert is_nil(Enum.find(job.communities, &(&1.id == community2.id)))
+      assert not is_nil(Enum.find(job.communities, &(&1.id == community2.id)))
     end
 
     test "job can be mirror to other community", ~m(user community community2 job_attrs)a do

test/groupher_server/cms/article_community/post_test.exs

@@ -34,7 +34,7 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Post do
       {:ok, post} = ORM.find(CMS.Post, post.id, preload: [:original_community, :communities])
 
       assert post.original_community.id == community2.id
-      assert is_nil(Enum.find(post.communities, &(&1.id == community2.id)))
+      assert not is_nil(Enum.find(post.communities, &(&1.id == community2.id)))
     end
 
     test "post can be mirror to other community", ~m(user community community2 post_attrs)a do

test/groupher_server/cms/article_community/repo_test.exs

@@ -34,7 +34,7 @@ defmodule GroupherServer.Test.CMS.ArticleCommunity.Repo do
       {:ok, repo} = ORM.find(CMS.Repo, repo.id, preload: [:original_community, :communities])
 
       assert repo.original_community.id == community2.id
-      assert is_nil(Enum.find(repo.communities, &(&1.id == community2.id)))
+      assert not is_nil(Enum.find(repo.communities, &(&1.id == community2.id)))
     end
 
     test "repo can be mirror to other community", ~m(user community community2 repo_attrs)a do

test/groupher_server_web/mutation/cms/article_community/post_test.exs

@@ -1,8 +1,8 @@
-defmodule GroupherServer.Test.Mutation.Articles.Post do
+defmodule GroupherServer.Test.Mutation.ArticleCommunity.Post do
   use GroupherServer.TestTools
 
-  alias Helper.{ORM, Utils}
-  alias GroupherServer.{CMS, Delivery}
+  alias Helper.ORM
+  alias GroupherServer.CMS
 
   setup do
     {:ok, post} = db_insert(:post)
@@ -122,7 +122,7 @@ defmodule GroupherServer.Test.Mutation.Articles.Post do
       }
     }
     """
-    test "auth user can set a community to post", ~m(post)a do
+    test "auth user can mirror a post to other community", ~m(post)a do
       passport_rules = %{"post.community.mirror" => true}
       rule_conn = simu_conn(:user, cms: passport_rules)
 
@@ -135,7 +135,7 @@ defmodule GroupherServer.Test.Mutation.Articles.Post do
       assert community.id in assoc_communities
     end
 
-    test "unauth user set a community to post fails", ~m(user_conn guest_conn post)a do
+    test "unauth user cannot mirror a post to a community", ~m(user_conn guest_conn post)a do
       {:ok, community} = db_insert(:community)
       variables = %{id: post.id, communityId: community.id}
       rule_conn = simu_conn(:user, cms: %{"what.ever" => true})
@@ -150,7 +150,7 @@ defmodule GroupherServer.Test.Mutation.Articles.Post do
              |> mutation_get_error?(@mirror_article_query, variables, ecode(:passport))
     end
 
-    test "auth user can set multi community to a post", ~m(post)a do
+    test "auth user can mirror multi post to other communities", ~m(post)a do
       passport_rules = %{"post.community.mirror" => true}
       rule_conn = simu_conn(:user, cms: passport_rules)
 
@@ -178,7 +178,7 @@ defmodule GroupherServer.Test.Mutation.Articles.Post do
     }
     """
     @tag :wip2
-    test "auth user can unset community from a post", ~m(post)a do
+    test "auth user can unmirror post to a community", ~m(post)a do
       passport_rules = %{"post.community.mirror" => true}
       rule_conn = simu_conn(:user, cms: passport_rules)
 
@@ -206,5 +206,42 @@ defmodule GroupherServer.Test.Mutation.Articles.Post do
       assert community.id not in assoc_communities
       assert community2.id in assoc_communities
     end
+
+    @move_article_query """
+    mutation($id: ID!, $communityId: ID!) {
+      moveArticle(id: $id, communityId: $communityId) {
+        id
+      }
+    }
+    """
+    @tag :wip2
+    test "auth user can move post to other community", ~m(post)a do
+      passport_rules = %{"post.community.mirror" => true}
+      rule_conn = simu_conn(:user, cms: passport_rules)
+
+      {:ok, community} = db_insert(:community)
+      {:ok, community2} = db_insert(:community)
+
+      variables = %{id: post.id, communityId: community.id}
+      rule_conn |> mutation_result(@mirror_article_query, variables, "mirrorArticle")
+      {:ok, found} = ORM.find(CMS.Post, post.id, preload: [:original_community, :communities])
+      assoc_communities = found.communities |> Enum.map(& &1.id)
+      assert community.id in assoc_communities
+
+      passport_rules = %{"post.community.move" => true}
+      rule_conn = simu_conn(:user, cms: passport_rules)
+
+      pre_original_community_id = found.original_community.id
+
+      variables = %{id: post.id, communityId: community2.id}
+      rule_conn |> mutation_result(@move_article_query, variables, "moveArticle")
+      {:ok, found} = ORM.find(CMS.Post, post.id, preload: [:original_community, :communities])
+      assoc_communities = found.communities |> Enum.map(& &1.id)
+      assert pre_original_community_id not in assoc_communities
+      assert community2.id in assoc_communities
+      assert community2.id == found.original_community_id
+
+      assert found.original_community.id == community2.id
+    end
   end
 end

test/groupher_server_web/query/cms/abuse_reports/job_report_test.exs

@@ -91,7 +91,7 @@ defmodule GroupherServer.Test.Query.AbuseReports.JobReport do
       assert results["totalCount"] == 1
     end
 
-    @tag :wip3
+    @tag :wip2
     test "support article_comment", ~m(guest_conn job user)a do
       {:ok, comment} = CMS.create_article_comment(:job, job.id, "comment", user)
       {:ok, _} = CMS.report_article_comment(comment.id, "reason", "attr", user)

test/groupher_server_web/query/cms/abuse_reports/post_report_test.exs

@@ -91,7 +91,7 @@ defmodule GroupherServer.Test.Query.AbuseReports.PostReport do
       assert results["totalCount"] == 1
     end
 
-    @tag :wip3
+    @tag :wip2
     test "support article_comment", ~m(guest_conn post user)a do
       {:ok, comment} = CMS.create_article_comment(:post, post.id, "comment", user)
       {:ok, _} = CMS.report_article_comment(comment.id, "reason", "attr", user)