fix(paged): total count error after pin contents

Author: mydearxym

lib/mastani_server/cms/delegates/article_curd.ex

@@ -382,16 +382,18 @@ defmodule MastaniServer.CMS.Delegate.ArticleCURD do
 
         normal_entries = normal_contents |> Map.get(:entries)
 
-        normal_count = normal_contents |> Map.get(:total_count)
         pind_count = pined_content |> Map.get(:total_count)
+        normal_count = normal_contents |> Map.get(:total_count)
 
         # remote the pined content from normal_entries (if have)
         pind_ids = pick_by(pind_entries, :id)
         normal_entries = Enum.reject(normal_entries, &(&1.id in pind_ids))
 
         normal_contents
         |> Map.put(:entries, pind_entries ++ normal_entries)
-        |> Map.put(:total_count, pind_count + normal_count)
+        # those two are equals
+        # |> Map.put(:total_count, pind_count + normal_count - pind_count)
+        |> Map.put(:total_count, normal_count)
         |> done
     end
   end

test/mastani_server_web/query/cms/jobs_flags_test.exs

@@ -67,7 +67,7 @@ defmodule MastaniServer.Test.Query.JobsFlags do
       results = guest_conn |> query_result(@query, variables, "pagedJobs")
       entries_first = results["entries"] |> List.first()
 
-      assert results["totalCount"] == @total_count + 1
+      assert results["totalCount"] == @total_count
       assert entries_first["id"] == to_string(job_m.id)
       assert entries_first["pin"] == true
     end

test/mastani_server_web/query/cms/posts_flags_test.exs

@@ -67,7 +67,7 @@ defmodule MastaniServer.Test.Query.PostsFlags do
       results = guest_conn |> query_result(@query, variables, "pagedPosts")
       entries_first = results["entries"] |> List.first()
 
-      assert results["totalCount"] == @total_count + 1
+      assert results["totalCount"] == @total_count
       assert entries_first["id"] == to_string(post_m.id)
       assert entries_first["pin"] == true
     end

test/mastani_server_web/query/cms/repos_flags_test.exs

@@ -66,7 +66,7 @@ defmodule MastaniServer.Test.Query.ReposFlags do
       results = guest_conn |> query_result(@query, variables, "pagedRepos")
       entries_first = results["entries"] |> List.first()
 
-      assert results["totalCount"] == @total_count + 1
+      assert results["totalCount"] == @total_count
       assert entries_first["id"] == to_string(repo_m.id)
       assert entries_first["pin"] == true
     end

test/mastani_server_web/query/cms/videos_flags_test.exs

@@ -66,7 +66,7 @@ defmodule MastaniServer.Test.Query.VideosFlags do
       results = guest_conn |> query_result(@query, variables, "pagedVideos")
       entries_first = results["entries"] |> List.first()
 
-      assert results["totalCount"] == @total_count + 1
+      assert results["totalCount"] == @total_count
       assert entries_first["id"] == to_string(video_m.id)
       assert entries_first["pin"] == true
     end