refactor: move set/unset article from/to community

Author: mydearxym

lib/groupher_server/cms/cms.ex

@@ -109,8 +109,9 @@ defmodule GroupherServer.CMS do
   defdelegate set_tag(thread, tag, content_id), to: ArticleOperation
   defdelegate unset_tag(thread, tag, content_id), to: ArticleOperation
   # >> community: set / unset
-  defdelegate set_community(community, thread, content_id), to: ArticleOperation
-  defdelegate unset_community(community, thread, content_id), to: ArticleOperation
+  defdelegate set_community(thread, article_id, community_id), to: ArticleOperation
+  defdelegate unset_community(thread, article_id, community_id), to: ArticleOperation
+  defdelegate move_article(thread, article_id, community_id), to: ArticleOperation
 
   defdelegate emotion_to_article(thread, article_id, args, user), to: ArticleEmotion
   defdelegate undo_emotion_to_article(thread, article_id, args, user), to: ArticleEmotion

lib/groupher_server/cms/delegates/article_curd.ex

@@ -130,19 +130,19 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
          {:ok, community} <- ORM.find(Community, cid) do
       Multi.new()
       |> Multi.run(:create_article, fn _, _ ->
-        do_create_content(action.target, attrs, author, community)
+        do_create_article(action.target, attrs, author, community)
       end)
-      |> Multi.run(:set_community, fn _, %{create_article: content} ->
-        ArticleOperation.set_community(community, thread, content.id)
+      |> Multi.run(:set_community, fn _, %{create_article: article} ->
+        ArticleOperation.set_community(thread, article.id, community.id)
       end)
-      |> Multi.run(:set_community_flag, fn _, %{create_article: content} ->
-        exec_set_community_flag(community, content, action)
+      |> Multi.run(:set_community_flag, fn _, %{create_article: article} ->
+        exec_set_community_flag(community, article, action)
       end)
-      |> Multi.run(:set_tag, fn _, %{create_article: content} ->
-        exec_set_tag(thread, content.id, attrs)
+      |> Multi.run(:set_tag, fn _, %{create_article: article} ->
+        exec_set_tag(thread, article.id, attrs)
       end)
-      |> Multi.run(:mention_users, fn _, %{create_article: content} ->
-        Delivery.mention_from_content(community.raw, thread, content, attrs, %User{id: uid})
+      |> Multi.run(:mention_users, fn _, %{create_article: article} ->
+        Delivery.mention_from_content(community.raw, thread, article, attrs, %User{id: uid})
         {:ok, :pass}
       end)
       |> Multi.run(:log_action, fn _, _ ->
@@ -160,7 +160,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
   """
   def notify_admin_new_content(%{id: id} = result) do
     target = result.__struct__
-    preload = [:origial_community, author: :user]
+    preload = [:original_community, author: :user]
 
     with {:ok, content} <- ORM.find(target, id, preload: preload) do
       info = %{
@@ -385,13 +385,13 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
   end
 
   #  for create content step in Multi.new
-  defp do_create_content(target, attrs, %Author{id: aid}, %Community{id: cid}) do
+  defp do_create_article(target, attrs, %Author{id: aid}, %Community{id: cid}) do
     target
     |> struct()
     |> target.changeset(attrs)
     |> Ecto.Changeset.put_change(:emotions, @default_emotions)
     |> Ecto.Changeset.put_change(:author_id, aid)
-    |> Ecto.Changeset.put_change(:origial_community_id, integerfy(cid))
+    |> Ecto.Changeset.put_change(:original_community_id, integerfy(cid))
     |> Ecto.Changeset.put_embed(:meta, @default_article_meta)
     |> Repo.insert()
   end

lib/groupher_server/cms/delegates/article_operation.ex

@@ -3,11 +3,12 @@ defmodule GroupherServer.CMS.Delegate.ArticleOperation do
   set / unset operations for Article-like resource
   """
   import GroupherServer.CMS.Helper.Matcher
+  import GroupherServer.CMS.Helper.Matcher2
   import Ecto.Query, warn: false
 
   import Helper.ErrorCode
   import ShortMaps
-  import Helper.Utils, only: [strip_struct: 1]
+  import Helper.Utils, only: [strip_struct: 1, integerfy: 1]
   import GroupherServer.CMS.Helper.Matcher2
 
   alias Helper.Types, as: T
@@ -104,24 +105,44 @@ defmodule GroupherServer.CMS.Delegate.ArticleOperation do
   @doc """
   set content to diffent community
   """
-  def set_community(%Community{id: community_id}, thread, content_id) do
-    with {:ok, action} <- match_action(thread, :community),
-         {:ok, content} <- ORM.find(action.target, content_id, preload: :communities),
-         {:ok, community} <- ORM.find(action.reactor, community_id) do
-      content
+  def set_community(thread, article_id, community_id) do
+    with {:ok, info} <- match(thread),
+         {:ok, article} <- ORM.find(info.model, article_id, preload: :communities),
+         {:ok, community} <- ORM.find(Community, community_id) do
+      article
       |> Ecto.Changeset.change()
-      |> Ecto.Changeset.put_assoc(:communities, content.communities ++ [community])
+      |> Ecto.Changeset.put_assoc(:communities, article.communities ++ [community])
       |> Repo.update()
     end
   end
 
-  def unset_community(%Community{id: community_id}, thread, content_id) do
-    with {:ok, action} <- match_action(thread, :community),
-         {:ok, content} <- ORM.find(action.target, content_id, preload: :communities),
-         {:ok, community} <- ORM.find(action.reactor, community_id) do
-      content
+  def unset_community(thread, article_id, community_id) do
+    with {:ok, info} <- match(thread),
+         {:ok, article} <-
+           ORM.find(info.model, article_id, preload: [:communities, :original_community]),
+         {:ok, community} <- ORM.find(Community, community_id) do
+      case article.original_community.id == community_id do
+        true ->
+          raise_error(:mirror_community, "can not unmirror original_community")
+
+        false ->
+          article
+          |> Ecto.Changeset.change()
+          |> Ecto.Changeset.put_assoc(:communities, article.communities -- [community])
+          |> Repo.update()
+      end
+    end
+  end
+
+  @doc """
+  set article original community in meta
+  """
+  def move_article(thread, article_id, community_id) do
+    with {:ok, info} <- match(thread),
+         {:ok, article} <- ORM.find(info.model, article_id) do
+      article
       |> Ecto.Changeset.change()
-      |> Ecto.Changeset.put_assoc(:communities, content.communities -- [community])
+      |> Ecto.Changeset.put_change(:original_community_id, integerfy(community_id))
       |> Repo.update()
     end
   end

lib/groupher_server/cms/embeds/article_meta.ex

@@ -6,6 +6,8 @@ defmodule GroupherServer.CMS.Embeds.ArticleMeta do
   use Accessible
   import Ecto.Changeset
 
+  alias GroupherServer.CMS
+
   @optional_fields ~w(is_edited is_comment_locked upvoted_user_ids collected_user_ids viewed_user_ids reported_user_ids reported_count)a
 
   @default_meta %{

lib/groupher_server/cms/job.ex

@@ -24,7 +24,7 @@ defmodule GroupherServer.CMS.Job do
 
   @timestamps_opts [type: :utc_datetime_usec]
   @required_fields ~w(title company company_logo body digest length)a
-  @optional_fields ~w(origial_community_id desc company_link link_addr copy_right salary exp education field finance scale article_comments_count article_comments_participators_count upvotes_count collects_count)a
+  @optional_fields ~w(original_community_id desc company_link link_addr copy_right salary exp education field finance scale article_comments_count article_comments_participators_count upvotes_count collects_count)a
 
   @type t :: %Job{}
   schema "cms_jobs" do
@@ -87,7 +87,7 @@ defmodule GroupherServer.CMS.Job do
       on_replace: :delete
     )
 
-    belongs_to(:origial_community, Community)
+    belongs_to(:original_community, Community)
 
     many_to_many(
       :communities,

lib/groupher_server/cms/post.ex

@@ -26,7 +26,7 @@ defmodule GroupherServer.CMS.Post do
 
   @timestamps_opts [type: :utc_datetime_usec]
   @required_fields ~w(title body digest length)a
-  @optional_fields ~w(origial_community_id link_addr copy_right link_addr link_icon article_comments_count article_comments_participators_count upvotes_count collects_count)a
+  @optional_fields ~w(original_community_id link_addr copy_right link_addr link_icon article_comments_count article_comments_participators_count upvotes_count collects_count)a
 
   @type t :: %Post{}
   schema "cms_posts" do
@@ -86,7 +86,7 @@ defmodule GroupherServer.CMS.Post do
       on_replace: :delete
     )
 
-    belongs_to(:origial_community, Community)
+    belongs_to(:original_community, Community)
 
     many_to_many(
       :communities,

lib/groupher_server/cms/repo.ex

@@ -25,7 +25,7 @@ defmodule GroupherServer.CMS.Repo do
 
   @timestamps_opts [type: :utc_datetime_usec]
   @required_fields ~w(title owner_name owner_url repo_url desc readme star_count issues_count prs_count fork_count watch_count upvotes_count collects_count)a
-  @optional_fields ~w(origial_community_id last_sync homepage_url release_tag license)a
+  @optional_fields ~w(original_community_id last_sync homepage_url release_tag license)a
 
   @type t :: %Repo{}
   schema "cms_repos" do
@@ -84,7 +84,7 @@ defmodule GroupherServer.CMS.Repo do
       on_replace: :delete
     )
 
-    belongs_to(:origial_community, Community)
+    belongs_to(:original_community, Community)
 
     many_to_many(
       :communities,

lib/groupher_server_web/resolvers/cms_resolver.ex

@@ -291,11 +291,11 @@ defmodule GroupherServerWeb.Resolvers.CMS do
   def community_subscribers(_root, _args, _info), do: {:error, "invalid args"}
 
   def set_community(_root, ~m(thread id community_id)a, _info) do
-    CMS.set_community(%Community{id: community_id}, thread, id)
+    CMS.set_community(thread, id, community_id)
   end
 
   def unset_community(_root, ~m(thread id community_id)a, _info) do
-    CMS.unset_community(%Community{id: community_id}, thread, id)
+    CMS.unset_community(thread, id, community_id)
   end
 
   # #######################

lib/groupher_server_web/schema/cms/cms_types.ex

@@ -67,7 +67,7 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
     field(:tags, list_of(:tag), resolve: dataloader(CMS, :tags))
 
     field(:author, :user, resolve: dataloader(CMS, :author))
-    field(:origial_community, :community, resolve: dataloader(CMS, :origial_community))
+    field(:original_community, :community, resolve: dataloader(CMS, :original_community))
     field(:communities, list_of(:community), resolve: dataloader(CMS, :communities))
 
     field(:meta, :article_meta)
@@ -123,7 +123,7 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
 
     field(:author, :user, resolve: dataloader(CMS, :author))
     field(:tags, list_of(:tag), resolve: dataloader(CMS, :tags))
-    field(:origial_community, :community, resolve: dataloader(CMS, :origial_community))
+    field(:original_community, :community, resolve: dataloader(CMS, :original_community))
     field(:communities, list_of(:community), resolve: dataloader(CMS, :communities))
 
     field(:meta, :article_meta)
@@ -177,7 +177,7 @@ defmodule GroupherServerWeb.Schema.CMS.Types do
     field(:last_sync, :datetime)
 
     field(:tags, list_of(:tag), resolve: dataloader(CMS, :tags))
-    field(:origial_community, :community, resolve: dataloader(CMS, :origial_community))
+    field(:original_community, :community, resolve: dataloader(CMS, :original_community))
     field(:communities, list_of(:community), resolve: dataloader(CMS, :communities))
 
     viewer_has_state_fields()

lib/helper/error_code.ex

@@ -46,6 +46,7 @@ defmodule Helper.ErrorCode do
   def ecode(:already_collected_in_folder), do: @article_base + 2
   def ecode(:delete_no_empty_collect_folder), do: @article_base + 3
   def ecode(:private_collect_folder), do: @article_base + 4
+  def ecode(:mirror_community), do: @article_base + 5
 
   def ecode, do: @default_base
   # def ecode(_), do: @default_base