refactor(pinned-article): wip

Author: mydearxym

test/groupher_server/cms/article_pin_test.exs

@@ -35,17 +35,16 @@ defmodule GroupherServer.Test.CMS.ArticlePin do
       assert pind_article.post_id == post.id
     end
 
-    @tag :wip
+    @tag :wip2
     test "one community & thread can only pin certern count of post", ~m(community post user)a do
-      {:ok, _post2} = CMS.create_content(community, :post, mock_attrs(:post), user)
-      {:ok, post3} = CMS.create_content(community, :post, mock_attrs(:post), user)
-
       Enum.reduce(1..@max_pinned_article_count_per_thread, [], fn _, acc ->
-        {:ok, _} = CMS.pin_article(:post, post.id, community.id)
+        {:ok, new_post} = CMS.create_content(community, :post, mock_attrs(:post), user)
+        {:ok, _} = CMS.pin_article(:post, new_post.id, community.id)
         acc
       end)
 
-      {:error, reason} = CMS.pin_article(:post, post3.id, community.id)
+      {:ok, new_post} = CMS.create_content(community, :post, mock_attrs(:post), user)
+      {:error, reason} = CMS.pin_article(:post, new_post.id, community.id)
       assert reason |> Keyword.get(:code) == ecode(:too_much_pinned_article)
     end
 
@@ -54,12 +53,11 @@ defmodule GroupherServer.Test.CMS.ArticlePin do
       assert {:error, _} = CMS.pin_article(:post, 8848, community.id)
     end
 
-    @tag :wip
+    @tag :wip2
     test "can undo pin to a post", ~m(community post)a do
       {:ok, _} = CMS.pin_article(:post, post.id, community.id)
 
       assert {:ok, unpinned} = CMS.undo_pin_article(:post, post.id, community.id)
-      assert unpinned.post_id == post.id
 
       assert {:error, _} = ORM.find_by(PinnedArticle, %{post_id: post.id})
     end

test/groupher_server_web/mutation/cms/cms_test.exs

@@ -216,7 +216,7 @@ defmodule GroupherServer.Test.Mutation.CMS.Basic do
       assert belong_community["id"] == to_string(community.id)
     end
 
-    # TODO: @tag :wip2
+    # TODO: @tag :wip
     # test "auth user create duplicate tag fails", ~m(community)a do
     #   variables = mock_attrs(:tag, %{communityId: community.id})
 

test/groupher_server_web/mutation/cms/job_flag_test.exs

@@ -112,7 +112,7 @@ defmodule GroupherServer.Test.Mutation.JobFlag do
       }
     }
     """
-    @tag :wip2
+    @tag :wip
     test "auth user can undo pin job", ~m(community job)a do
       variables = %{id: job.id, communityId: community.id}
 

test/groupher_server_web/mutation/cms/post_flag_test.exs

@@ -84,7 +84,7 @@ defmodule GroupherServer.Test.Mutation.PostFlag do
       }
     }
     """
-    @tag :wip2
+    @tag :wip
     test "auth user can pin post", ~m(community post)a do
       variables = %{id: post.id, communityId: community.id}
 
@@ -113,7 +113,7 @@ defmodule GroupherServer.Test.Mutation.PostFlag do
       }
     }
     """
-    @tag :wip2
+    @tag :wip
     test "auth user can undo pin post", ~m(community post)a do
       variables = %{id: post.id, communityId: community.id}
 

test/groupher_server_web/mutation/cms/repo_flag_test.exs

@@ -112,7 +112,7 @@ defmodule GroupherServer.Test.Mutation.RepoFlag do
       }
     }
     """
-    @tag :wip2
+    @tag :wip
     test "auth user can undo pin repo", ~m(community repo)a do
       variables = %{id: repo.id, communityId: community.id}
 

test/groupher_server_web/query/cms/jobs_flags_test.exs

@@ -51,7 +51,7 @@ defmodule GroupherServer.Test.Query.JobsFlags do
       }
     }
     """
-    @tag :wip2
+    @tag :wip
     test "if have pined jobs, the pined jobs should at the top of entries",
          ~m(guest_conn community job_m)a do
       variables = %{filter: %{community: community.raw}}
@@ -73,7 +73,7 @@ defmodule GroupherServer.Test.Query.JobsFlags do
       assert entries_first["isPinned"] == true
     end
 
-    @tag :wip2
+    @tag :wip
     test "pind jobs should not appear when page > 1", ~m(guest_conn community)a do
       variables = %{filter: %{page: 2, size: 20}}
       results = guest_conn |> query_result(@query, variables, "pagedJobs")

test/groupher_server_web/query/cms/posts_flags_test.exs

@@ -51,7 +51,7 @@ defmodule GroupherServer.Test.Query.PostsFlags do
       }
     }
     """
-    @tag :wip2
+    @tag :wip
     test "if have pined posts, the pined posts should at the top of entries",
          ~m(guest_conn community post_m)a do
       variables = %{filter: %{community: community.raw}}
@@ -73,7 +73,7 @@ defmodule GroupherServer.Test.Query.PostsFlags do
       assert entries_first["isPinned"] == true
     end
 
-    @tag :wip2
+    @tag :wip
     test "pind posts should not appear when page > 1", ~m(guest_conn community)a do
       variables = %{filter: %{page: 2, size: 20}}
       results = guest_conn |> query_result(@query, variables, "pagedPosts")

test/groupher_server_web/query/cms/repos_flags_test.exs

@@ -71,7 +71,7 @@ defmodule GroupherServer.Test.Query.ReposFlags do
       assert entries_first["isPinned"] == true
     end
 
-    @tag :wip2
+    @tag :wip
     test "pind repos should not appear when page > 1", ~m(guest_conn community)a do
       variables = %{filter: %{page: 2, size: 20}}
       results = guest_conn |> query_result(@query, variables, "pagedRepos")