refactor(article-emotions): fix broken test

Author: mydearxym

lib/groupher_server/cms/delegates/helper.ex

@@ -28,6 +28,7 @@ defmodule GroupherServer.CMS.Delegate.Helper do
         %User{} = user,
         type \\ :article
       ) do
+    IO.inspect("hello?")
     supported_emotions = get_supported_mentions(type)
 
     new_entries =

lib/groupher_server_web/middleware/pagesize_proof.ex

@@ -45,11 +45,8 @@ defmodule GroupherServerWeb.Middleware.PageSizeProof do
 
   def call(resolution, _) do
     case valid_size(resolution.arguments) do
-      {:error, msg} ->
-        resolution |> handle_absinthe_error(msg, ecode(:pagination))
-
-      arguments ->
-        %{resolution | arguments: sort_desc_by_default(arguments)}
+      {:error, msg} -> resolution |> handle_absinthe_error(msg, ecode(:pagination))
+      arguments -> %{resolution | arguments: sort_desc_by_default(arguments)}
     end
   end
 

lib/groupher_server_web/resolvers/cms_resolver.ex

@@ -55,6 +55,7 @@ defmodule GroupherServerWeb.Resolvers.CMS do
   end
 
   def paged_articles(_root, ~m(thread filter)a, %{context: %{cur_user: user}}) do
+    IO.inspect(filter, label: "the filter")
     CMS.paged_articles(thread, filter, user)
   end
 

test/groupher_server_web/mutation/accounts/customization_test.exs

@@ -72,7 +72,7 @@ defmodule GroupherServer.Test.Mutation.Account.Customization do
       }
     }
     """
-    @tag :wip3
+    @tag :wip2
     test "PageSizeProof middleware should lint c11n displayDensity size", ~m(user)a do
       user_conn = simu_conn(:user, user)
       db_insert_multi(:post, 50)

test/groupher_server_web/query/cms/jobs_flags_test.exs

@@ -51,7 +51,7 @@ defmodule GroupherServer.Test.Query.JobsFlags do
       }
     }
     """
-    @tag :wip2
+    @tag :wip3
     test "if have pined jobs, the pined jobs should at the top of entries",
          ~m(guest_conn community job_m)a do
       variables = %{filter: %{community: community.raw}}

test/groupher_server_web/query/cms/posts_flags_test.exs

@@ -51,7 +51,7 @@ defmodule GroupherServer.Test.Query.PostsFlags do
       }
     }
     """
-    @tag :wip2
+    @tag :wip3
     test "if have pined posts, the pined posts should at the top of entries",
          ~m(guest_conn community post_m)a do
       variables = %{filter: %{community: community.raw}}

test/groupher_server_web/query/cms/repos_flags_test.exs

@@ -50,7 +50,7 @@ defmodule GroupherServer.Test.Query.ReposFlags do
       }
     }
     """
-    @tag :wip2
+    @tag :wip3
     test "if have pined repos, the pined repos should at the top of entries",
          ~m(guest_conn community repo_m)a do
       variables = %{filter: %{community: community.raw}}

test/support/factory.ex

@@ -10,6 +10,8 @@ defmodule GroupherServer.Support.Factory do
   alias GroupherServer.Repo
   alias GroupherServer.{Accounts, CMS, Delivery}
 
+  @default_emotions CMS.Embeds.ArticleCommentEmotion.default_emotions()
+
   defp mock_meta(:post) do
     body = Faker.Lorem.sentence(%Range{first: 80, last: 120})
 
@@ -23,7 +25,8 @@ defmodule GroupherServer.Support.Factory do
       communities: [
         mock(:community),
         mock(:community)
-      ]
+      ],
+      emotions: @default_emotions
     }
   end
 
@@ -58,7 +61,8 @@ defmodule GroupherServer.Support.Factory do
       communities: [
         mock(:community),
         mock(:community)
-      ]
+      ],
+      emotions: @default_emotions
     }
   end
 
@@ -121,7 +125,8 @@ defmodule GroupherServer.Support.Factory do
       scale: scale_enum |> Enum.at(Enum.random(0..(length(scale_enum) - 1))),
       communities: [
         mock(:community)
-      ]
+      ],
+      emotions: @default_emotions
     }
   end