refactor(pinned-article): fix pined test & re-org

Author: mydearxym

lib/groupher_server/cms/cms.ex

@@ -88,8 +88,6 @@ defmodule GroupherServer.CMS do
   defdelegate set_community_flags(community_info, queryable, attrs), to: ArticleOperation
   defdelegate pin_article(thread, id, community_id), to: ArticleOperation
   defdelegate undo_pin_article(thread, id, community_id), to: ArticleOperation
-  defdelegate pin_content(queryable, community_id), to: ArticleOperation
-  defdelegate undo_pin_content(queryable, community_id), to: ArticleOperation
 
   defdelegate lock_article_comment(content), to: ArticleOperation
 

lib/groupher_server/cms/delegates/article_curd.ex

@@ -323,7 +323,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
     pind_entries =
       pined_content
       |> Map.get(:entries)
-      |> Enum.map(&struct(&1, %{pin: true}))
+      |> Enum.map(&struct(&1, %{is_pinned: true}))
 
     normal_entries = normal_contents |> Map.get(:entries)
 

lib/groupher_server/cms/delegates/article_operation.ex

@@ -21,10 +21,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleOperation do
     JobCommunityFlag,
     RepoCommunityFlag,
     Tag,
-    PinnedArticle,
-    PinedPost,
-    PinedJob,
-    PinedRepo
+    PinnedArticle
   }
 
   alias GroupherServer.CMS.Repo, as: CMSRepo
@@ -63,54 +60,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleOperation do
         )
 
       ORM.findby_delete(PinnedArticle, args)
-    end
-  end
-
-  def pin_content(%Post{id: post_id}, %Community{id: community_id}) do
-    with {:ok, pined} <-
-           ORM.findby_or_insert(
-             PinedPost,
-             ~m(post_id community_id)a,
-             ~m(post_id community_id)a
-           ) do
-      Post |> ORM.find(pined.post_id)
-    end
-  end
-
-  def pin_content(%Job{id: job_id}, %Community{id: community_id}) do
-    attrs = ~m(job_id community_id)a
-
-    with {:ok, pined} <- ORM.findby_or_insert(PinedJob, attrs, attrs) do
-      Job |> ORM.find(pined.job_id)
-    end
-  end
-
-  def pin_content(%CMSRepo{id: repo_id}, %Community{id: community_id}) do
-    attrs = ~m(repo_id community_id)a
-
-    with {:ok, pined} <- ORM.findby_or_insert(PinedRepo, attrs, attrs) do
-      CMSRepo |> ORM.find(pined.repo_id)
-    end
-  end
-
-  def undo_pin_content(%Post{id: post_id}, %Community{id: community_id}) do
-    with {:ok, pined} <- ORM.find_by(PinedPost, ~m(post_id community_id)a),
-         {:ok, deleted} <- ORM.delete(pined) do
-      Post |> ORM.find(deleted.post_id)
-    end
-  end
-
-  def undo_pin_content(%Job{id: job_id}, %Community{id: community_id}) do
-    with {:ok, pined} <- ORM.find_by(PinedJob, ~m(job_id community_id)a),
-         {:ok, deleted} <- ORM.delete(pined) do
-      Job |> ORM.find(deleted.job_id)
-    end
-  end
-
-  def undo_pin_content(%CMSRepo{id: repo_id}, %Community{id: community_id}) do
-    with {:ok, pined} <- ORM.find_by(PinedRepo, ~m(repo_id community_id)a),
-         {:ok, deleted} <- ORM.delete(pined) do
-      CMSRepo |> ORM.find(deleted.repo_id)
+      ORM.find(info.model, article_id)
     end
   end
 

lib/groupher_server/cms/job.ex

@@ -56,7 +56,7 @@ defmodule GroupherServer.CMS.Job do
     has_many(:community_flags, {"jobs_communities_flags", JobCommunityFlag})
 
     # NOTE: this one is tricky, pin is dynamic changed when return by func: add_pin_contents_ifneed
-    field(:pin, :boolean, default_value: false, virtual: true)
+    field(:is_pinned, :boolean, default: false, virtual: true)
     field(:trash, :boolean, default_value: false, virtual: true)
 
     has_many(:article_comments, {"articles_comments", ArticleComment})

lib/groupher_server/cms/pined_job.ex

@@ -6,15 +6,16 @@ defmodule GroupherServer.CMS.PinnedArticle do
   import Ecto.Changeset
 
   alias GroupherServer.CMS
-  alias CMS.{Community, Post, Job}
+  alias CMS.{Community, Post, Job, Repo}
 
   @required_fields ~w(community_id thread)a
-  @optional_fields ~w(post_id job_id)a
+  @optional_fields ~w(post_id job_id repo_id)a
 
   @type t :: %PinnedArticle{}
   schema "pinned_articles" do
     belongs_to(:post, Post, foreign_key: :post_id)
     belongs_to(:job, Job, foreign_key: :job_id)
+    belongs_to(:repo, Repo, foreign_key: :repo_id)
     belongs_to(:community, Community, foreign_key: :community_id)
 
     field(:thread, :string)
@@ -29,8 +30,11 @@ defmodule GroupherServer.CMS.PinnedArticle do
     |> validate_required(@required_fields)
     |> foreign_key_constraint(:post_id)
     |> foreign_key_constraint(:job_id)
+    |> foreign_key_constraint(:repo_id)
     |> foreign_key_constraint(:community_id)
+    |> unique_constraint(:pinned_articles, name: :pinned_articles_post_id_community_id_index)
 
-    # |> unique_constraint(:pined_posts, name: :pined_posts_post_id_community_id_index)
+    # |> unique_constraint(:pinned_articles, name: :pinned_articles_job_id_community_id_index)
+    # |> unique_constraint(:pinned_articles, name: :pinned_articles_repo_id_community_id_index)
   end
 end

lib/groupher_server/cms/pined_post.ex

@@ -45,7 +45,8 @@ defmodule GroupherServer.CMS.Post do
     has_many(:community_flags, {"posts_communities_flags", PostCommunityFlag})
 
     # NOTE: this one is tricky, pin is dynamic changed when return by func: add_pin_contents_ifneed
-    field(:pin, :boolean, default_value: false, virtual: true)
+    # field(:pin, :boolean, default_value: false, virtual: true)
+    field(:is_pinned, :boolean, default: false, virtual: true)
     field(:trash, :boolean, default_value: false, virtual: true)
 
     belongs_to(:author, Author)

lib/groupher_server/cms/pined_repo.ex

@@ -56,7 +56,7 @@ defmodule GroupherServer.CMS.Repo do
     has_many(:community_flags, {"repos_communities_flags", RepoCommunityFlag})
 
     # NOTE: this one is tricky, pin is dynamic changed when return by func: add_pin_contents_ifneed
-    field(:pin, :boolean, default_value: false)
+    field(:is_pinned, :boolean, default: false, virtual: true)
     field(:trash, :boolean, default_value: false)
 
     field(:last_sync, :utc_datetime)