refactor(article-comments): helper for raise custom error

Author: mydearxym

lib/groupher_server/cms/delegates/article_comment.ex

@@ -4,6 +4,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
   """
   import Ecto.Query, warn: false
   import Helper.Utils, only: [done: 1]
+  import Helper.ErrorCode
 
   import GroupherServer.CMS.Utils.Matcher2
   import ShortMaps
@@ -682,8 +683,8 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
   defp upsert_comment_result({:ok, %{update_comment_flag: result}}), do: {:ok, result}
   defp upsert_comment_result({:ok, %{delete_article_comment: result}}), do: {:ok, result}
 
-  defp upsert_comment_result({:error, :create_comment, result, _steps}) do
-    {:error, result}
+  defp upsert_comment_result({:error, :create_article_comment, result, _steps}) do
+    raise_error(:create_comment, result)
   end
 
   defp upsert_comment_result({:error, :add_participator, result, _steps}) do

lib/helper/error_code.ex

@@ -6,6 +6,12 @@ defmodule Helper.ErrorCode do
   @changeset_base 4100
   @throttle_base 4200
   @account_base 4300
+  @comment_base 4400
+
+  @spec raise_error(Atom.t(), String.t()) :: {:error, [message: String.t(), code: Integer.t()]}
+  def raise_error(code_atom, msg) do
+    {:error, [message: msg, code: ecode(code_atom)]}
+  end
 
   # account error code
   def ecode(:account_login), do: @account_base + 1
@@ -32,6 +38,9 @@ defmodule Helper.ErrorCode do
   def ecode(:throttle_inverval), do: @throttle_base + 1
   def ecode(:throttle_hour), do: @throttle_base + 2
   def ecode(:throttle_day), do: @throttle_base + 3
+  #
+  def ecode(:create_comment), do: @comment_base + 1
+
   def ecode, do: @default_base
   # def ecode(_), do: @default_base
 end

test/groupher_server/cms/article_comment_test.exs

@@ -318,7 +318,7 @@ defmodule GroupherServer.Test.CMS.ArticleComment do
   end
 
   describe "paged article comments" do
-    @tag :wip2
+    @tag :wip
     test "can load paged comments participators of a article", ~m(user post)a do
       total_count = 30
       page_number = 1

test/groupher_server_web/query/cms/article_comment_test.exs

@@ -509,7 +509,7 @@ defmodule GroupherServer.Test.Query.ArticleComment do
         }
     }
     """
-    @tag :wip2
+    @tag :wip
     test "guest user can get paged participators", ~m(guest_conn post user)a do
       total_count = 30
       page_size = 10