chore: Merge branch 'git-repo' into dev

Author: mydearxym

lib/groupher_server_web/schema/cms/mutations/repo.ex

@@ -38,6 +38,37 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Repo do
       middleware(M.Statistics.MakeContribute, for: [:user, :community])
     end
 
+    @desc "update a cms/repo"
+    field :update_repo, :repo do
+      arg(:id, non_null(:id))
+      arg(:title, :string)
+      arg(:owner_name, :string)
+      arg(:owner_url, :string)
+      arg(:repo_url, :string)
+
+      arg(:desc, :string)
+      arg(:homepage_url, :string)
+      arg(:readme, :string)
+
+      arg(:star_count, :integer)
+      arg(:issues_count, :integer)
+      arg(:prs_count, :integer)
+      arg(:fork_count, :integer)
+      arg(:watch_count, :integer)
+
+      arg(:license, :string)
+      arg(:release_tag, :string)
+
+      arg(:contributors, list_of(:repo_contributor_input))
+      arg(:primary_language, :repo_lang_input)
+
+      middleware(M.Authorize, :login)
+      middleware(M.PassportLoader, source: :repo)
+      middleware(M.Passport, claim: "owner;cms->c?->repo.edit")
+
+      resolve(&R.CMS.update_content/3)
+    end
+
     @desc "pin a repo"
     field :pin_repo, :repo do
       arg(:id, non_null(:id))
@@ -98,26 +129,5 @@ defmodule GroupherServerWeb.Schema.CMS.Mutations.Repo do
 
       resolve(&R.CMS.delete_content/3)
     end
-
-    @desc "update a cms/repo"
-    field :update_repo, :repo do
-      arg(:repo_name, non_null(:string))
-      arg(:desc, non_null(:string))
-      arg(:readme, non_null(:string))
-      arg(:language, non_null(:string))
-      arg(:repo_link, non_null(:string))
-      arg(:producer, non_null(:string))
-      arg(:producer_link, non_null(:string))
-
-      arg(:repo_star_count, non_null(:integer))
-      arg(:repo_fork_count, non_null(:integer))
-      arg(:repo_watch_count, non_null(:integer))
-
-      middleware(M.Authorize, :login)
-      middleware(M.PassportLoader, source: :repo)
-      middleware(M.Passport, claim: "owner;cms->c?->repo.edit")
-
-      resolve(&R.CMS.update_content/3)
-    end
   end
 end

test/groupher_server_web/mutation/cms/repo_test.exs

@@ -82,5 +82,95 @@ defmodule GroupherServer.Test.Mutation.Repo do
       assert created["origialCommunity"]["id"] == to_string(community.id)
       assert {:ok, _} = ORM.find_by(CMS.Author, user_id: user.id)
     end
+
+    @update_repo_query """
+    mutation(
+      $id: ID!,
+      $title: String,
+      $ownerName: String,
+      $ownerUrl: String,
+      $repoUrl: String,
+      $desc: String,
+      $homepageUrl: String,
+      $readme: String,
+      $starCount: Int,
+      $issuesCount: Int,
+      $prsCount: Int,
+      $forkCount: Int,
+      $watchCount: Int,
+      $license: String,
+      $releaseTag: String,
+      $primaryLanguage: RepoLangInput,
+      $contributors: [RepoContributorInput],
+    ) {
+      updateRepo(
+        id: $id,
+        title: $title,
+        ownerName: $ownerName,
+        ownerUrl: $ownerUrl,
+        repoUrl: $repoUrl,
+        desc: $desc,
+        homepageUrl: $homepageUrl,
+        readme: $readme,
+        starCount: $starCount,
+        issuesCount: $issuesCount,
+        prsCount: $prsCount,
+        forkCount: $forkCount,
+        watchCount: $watchCount,
+        primaryLanguage: $primaryLanguage,
+        license: $license,
+        releaseTag: $releaseTag,
+        contributors: $contributors,
+      ) {
+        id
+        title
+        readme
+        desc
+        origialCommunity {
+          id
+        }
+      }
+    }
+    """
+    test "update git-repo with valid attrs" do
+      {:ok, user} = db_insert(:user)
+      user_conn = simu_conn(:user, user)
+      {:ok, community} = db_insert(:community)
+      repo_attr = mock_attrs(:repo) |> camelize_map_key
+      variables = repo_attr |> Map.merge(%{communityId: community.id})
+      created = user_conn |> mutation_result(@create_repo_query, variables, "createRepo")
+      {:ok, repo} = ORM.find(CMS.Repo, created["id"])
+
+      updated =
+        user_conn
+        |> mutation_result(
+          @update_repo_query,
+          %{id: repo.id, title: "new title", readme: "new readme"},
+          "updateRepo"
+        )
+
+      # IO.inspect(updated, label: "hello")
+      assert updated["title"] == "new title"
+      assert updated["readme"] == "new readme"
+    end
+
+    test "unauth user update git-repo fails", ~m(user_conn guest_conn repo)a do
+      unique_num = System.unique_integer([:positive, :monotonic])
+
+      variables = %{
+        id: repo.id,
+        title: "updated title #{unique_num}",
+        body: "updated body #{unique_num}"
+      }
+
+      rule_conn = simu_conn(:user, cms: %{"what.ever" => true})
+
+      assert user_conn |> mutation_get_error?(@update_repo_query, variables, ecode(:passport))
+
+      assert guest_conn
+             |> mutation_get_error?(@update_repo_query, variables, ecode(:account_login))
+
+      assert rule_conn |> mutation_get_error?(@update_repo_query, variables, ecode(:passport))
+    end
   end
 end

test/support/assert_helper.ex

@@ -87,24 +87,25 @@ defmodule GroupherServer.Test.AssertHelper do
   @doc """
   simulate the Graphiql murate operation
   """
-  def mutation_result(conn, query, variables, key) do
+  def mutation_result(conn, query, variables, key, flag \\ false) do
     conn
     |> post("/graphiql", query: query, variables: variables)
     |> json_response(200)
-    # |> IO.inspect(label: "debug")
+    |> log_debug_info(flag)
     |> Map.get("data")
     |> Map.get(key)
   end
 
   @doc """
   check if Graphiql murate get error
   """
-  def mutation_get_error?(conn, query, variables) do
+  def mutation_get_error?(conn, query, variables, flag \\ false)
+
+  def mutation_get_error?(conn, query, variables, flag) do
     conn
     |> post("/graphiql", query: query, variables: variables)
-    # |> IO.inspect(label: "debug status")
     |> json_response(200)
-    # |> IO.inspect(label: "debug")
+    |> log_debug_info(flag)
     |> Map.has_key?("errors")
   end
 
@@ -128,11 +129,11 @@ defmodule GroupherServer.Test.AssertHelper do
     end
   end
 
-  def query_result(conn, query, variables, key) do
+  def query_result(conn, query, variables, key, flag \\ false) do
     conn
     |> get("/graphiql", query: query, variables: variables)
     |> json_response(200)
-    # |> IO.inspect(label: "debug")
+    |> log_debug_info(flag)
     |> Map.get("data")
     |> Map.get(key)
   end
@@ -176,4 +177,11 @@ defmodule GroupherServer.Test.AssertHelper do
 
     [value_1, value_2, value_3, value_x]
   end
+
+  # log response info if need
+  # usage:
+  # user_conn |> mutation_result(@query, variables, "createRepo")
+  # user_conn |> mutation_result(@query, variables, "createRepo", :debug)
+  defp log_debug_info(res, :debug), do: IO.inspect(res, label: "debug")
+  defp log_debug_info(res, _), do: res
 end